Merge pull request kubevirt#666 from davidvossel/build-fix

Fixes build errors
portalgun-io · Jan 19, 2018 · a7fb2ed · a7fb2ed
2 parents e4eaf19 + 2b47521
commit a7fb2ed
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/hack/gen-swagger-doc/gen-swagger-docs.sh b/hack/gen-swagger-doc/gen-swagger-docs.sh
@@ -10,8 +10,11 @@ set -o pipefail
 
 source $(dirname "$0")/../../hack/common.sh
 
-VERSION="${1:-v1}"
-OUTPUT_FORMAT="${2:-html}"
+VERSION="$1"
+OUTPUT_FORMAT="$2"
+
+VERSION="${VERSION:-v1}"
+OUTPUT_FORMAT="${OUTPUT_FORMAT:-html}"
 GIT_REPO_LINK="https://github.com/kubevirt/kubevirt"
 if [ "$OUTPUT_FORMAT" = "html" ]; then
     SUFFIX="adoc"

diff --git a/hack/release-announce.sh b/hack/release-announce.sh
@@ -101,8 +101,10 @@ EOF
 #
 # Let's get the party started
 #
-RELREF=${1:-$(git describe --abbrev=0 --tags)}
-PREREF=${2:-$(git describe --abbrev=0 --tags $RELREF^)}
+RELREF="$1"
+PREREF="$2"
+RELREF=${RELREF:-$(git describe --abbrev=0 --tags)}
+PREREF=${PREREF:-$(git describe --abbrev=0 --tags $RELREF^)}
 RELSPANREF=$PREREF..$RELREF
 
 main