Clean Up /contact-us Page, Fix "Contact us" Footer Link, and Update terms_of_use_path
#978
+11
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dummy values for `telephone`, `address`, and `google_maps_link` were being rendered within the `/contact-us` page. This commit sets them to nil, which avoids confusion by not rendering any values at all.
`app/views/contact_us/contacts/_new_right.html.erb` references these variables. However, it does so without underscores. (However, we probably didn't want the values to render in the first place, so we're probably lucky.)
Prior to this change, users were being routed to portagenetwork.ca when clicking "Contact us" in the footer. This could have lead to users being misplaced into the Portage Network help queue, rather than the intended DMP Assistant help queue. Removing the `contact_us_path` helper method now results in the following behaviour for `contact_us_path`: 3.1.4 :001 > Rails.application.routes.url_helpers.contact_us_path => "/contact-us" 3.1.4 :002 > I18n.locale = :'fr-CA' => :"fr-CA" 3.1.4 :003 > Rails.application.routes.url_helpers.contact_us_path => "/contact-us"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961
Changes proposed in this PR:
/contact-uspage.config.x.organisation.addressto properly correspond with variable names withinapp/views/contact_us/contacts/_new_right.html.erb.contact_us_pathcontact_us_pathnow defaults to the following via thecontact_usgem:def terms_of_use_path'/terms'now