Add Rake Task to Remove Deprecated Permissions #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
This rake task removes deprecated permissions both from users and from the perms db table itself.
aaronskiba
force-pushed
the
aaron/issues/828
branch
from
c6c1142 to
9bc5d7e
Compare
lagoan
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
This code looks good to me ! We have made rake tasks like this to handle data modification in the past. I just pushed a PR handling this type of issue as a migration instead of a rake task.
I like the idea of a migration since it wont be a part of the code that we will continue to keep in mind.
That approach can have its drawbacks too.
What do you think about these 2 approaches ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #828
Changes proposed in this PR: