Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO CILogon config changes #812

Closed
wants to merge 37 commits into from
Closed

Conversation

200455939-yashu
Copy link
Collaborator

Fixes # .

Changes proposed in this PR: CILogon changes are in process. CILogon changes are introduced here.

Copy link

github-actions bot commented Jun 28, 2024

1 Error
🚫 Please include a CHANGELOG entry. You can find it at CHANGELOG.md.
1 Warning
⚠️ This PR is too big! Consider breaking it down into smaller PRs.

Generated by 🚫 Danger

200455939-yashu and others added 19 commits July 9, 2024 11:00
Adding some missing methods and start cleanup.

We still need to clean up and fix the `openid_connect` method on
`omniauth_callbacks_controller.rb`.
Here we have a first pass of working integration tests for omniauth SSO.

The tests still need to check for the messages we are setting as
notifications.

We can think about splitting the tests into integration and controller
tests.
@aaronskiba aaronskiba closed this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants