Modify db_fields hash in translation.rb config
#745
+17
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code to handle |
|
Some manual testing of this PR is documented in issue #553. |
aaronskiba
commented
Jul 3, 2024
aaronskiba
force-pushed
the
aaron/issues/553
branch
from
bb98903 to
9636ed7
Compare
aaronskiba
force-pushed
the
aaron/issues/553
branch
from
9636ed7 to
2ab707e
Compare
This commit modifies how the templates-related tables ('templates', 'phases', 'sections', 'questions', 'annotations', and 'question_options') are queried within our customisation of the translation gem. All of those related tables are removed from config.db_fields. However, the tables (along with their previously specified columns) are now all included in the newly added Template ActiveRecord query (line 24). Rather than returning all of the db entries, this query only returns those that relate to the app's default_org.
`'CallableQueries' => [templates_data_for_default_org_proc]` has been added to config.db_fields.`def templates_data_for_default_org_proc` returns a proc. This proc will be called within the translation gem, where it will execute the aforementioned Template ActiveRecord query. Finally, the returned entries will be uploaded to translation.io.
aaronskiba
force-pushed
the
aaron/issues/553
branch
from
2ab707e to
a51657a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #553
Changes proposed in this PR:
'CallableQueries' => [templates_data_for_default_org_proc]has been added to config.db_fields.def templates_data_for_default_org_procreturns a proc. This proc will be called within the translation gem, where it will execute the aforementioned Template ActiveRecord query. Finally, the returned entries will be uploaded to translation.io.