Updated Pagerduty Self Service GitHub Actions #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
mk-armah
changed the title
mk-armah
changed the title
pazhersh
reviewed
May 19, 2024
| @@ -191,8 +192,9 @@ Create a new self service action using the following JSON configuration. | |||
| "{{if (.inputs | has(\"from\")) then \"from\" else null end}}": "{{.inputs.\"from\"}}", | |||
There was a problem hiding this comment.
Suggested change
| "{{if (.inputs | has(\"from\")) then \"from\" else null end}}": "{{.inputs.\"from\"}}", | |
| "from": "{{.inputs.\"from\"}}", | |
| @@ -250,16 +251,17 @@ Create a new self service action using the following JSON configuration. | |||
| "type": "GITHUB", | |||
| "org": "<GITHUB_ORG>", | |||
| "repo": "<GITHUB_REPO>", | |||
| "workflow": "change-incident-owner.yaml", | |||
| "workflow": "change-on-call-user.yaml", | |||
| "workflowInputs": { | |||
| "{{if (.inputs | has(\"ref\")) then \"ref\" else null end}}": "{{.inputs.\"ref\"}}", | |||
| "{{if (.inputs | has(\"start_time\")) then \"start_time\" else null end}}": "{{.inputs.\"start_time\"}}", | |||
| "{{if (.inputs | has(\"end_time\")) then \"end_time\" else null end}}": "{{.inputs.\"end_time\"}}", | |||
| "{{if (.inputs | has(\"new_on_call_user\")) then \"new_on_call_user\" else null end}}": "{{.inputs.\"new_on_call_user\"}}", | |||
There was a problem hiding this comment.
all the inputs here too could go through this change:
Suggested change
| "{{if (.inputs | has(\"new_on_call_user\")) then \"new_on_call_user\" else null end}}": "{{.inputs.\"new_on_call_user\"}}", | |
| "new_on_call_user": "{{.inputs.\"new_on_call_user\"}}", | |
There was a problem hiding this comment.
Thats relevant for the other files in this PR as well
...ice-experiences/setup-backend/github-workflow/examples/PagerDuty/create-pagerduty-service.md
Show resolved
Hide resolved
...e-experiences/setup-backend/github-workflow/examples/PagerDuty/trigger-pagerduty-incident.md
Show resolved
Hide resolved
yairsimantov20
requested changes
May 23, 2024
pazhersh
approved these changes
May 23, 2024
...ice-experiences/setup-backend/github-workflow/examples/PagerDuty/create-pagerduty-service.md
Show resolved
Hide resolved
yairsimantov20
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Improved existing pagerduty guides and fixed bug in obtaining the entity ids
Updated docs pages
/create-self-service-experiences/setup-backend/github-workflow/examples/PagerDuty/
BugFix
.entity.identifierImprovement
relationsfield to all DAY-2 actionscreate-pagerduty-serviceandtrigger incidentactions to report updated runs back to port