Port 8079 update GitHub actions for aws #1212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
pazhersh
reviewed
May 19, 2024
...ate-self-service-experiences/setup-backend/github-workflow/examples/AWS/push-image-to-ecr.md
Show resolved
Hide resolved
pazhersh
reviewed
May 20, 2024
| } | ||
| "repository": "{{ .inputs.\"repository\" }}", | ||
| "tags": "{{ .inputs.\"tags\" }}", | ||
| "context": { |
There was a problem hiding this comment.
Can you please rename it to port_context?
There was a problem hiding this comment.
Relevant for the other files in the PR as well
| @@ -238,11 +212,10 @@ on: | |||
| type: string | |||
| required: true | |||
| description: 'Tags should be in key-value pairs like so: {"key": "value"}' | |||
| port_payload: | |||
| context: | |||
There was a problem hiding this comment.
don't forget to rename here too :)
pazhersh
reviewed
May 21, 2024
| "ec2_name": "{{ .inputs.\"ec2_name\" }}", | ||
| "ec2_instance_type": "{{ .inputs.\"ec2_instance_type\" }}", | ||
| "pem_key_name": "{{ .inputs.\"pem_key_name\" }}", | ||
| "context": { |
There was a problem hiding this comment.
Suggested change
| "context": { | |
| "port_context": { |
| @@ -288,7 +288,7 @@ on: | |||
| description: EC2 pem key | |||
| required: true | |||
| type: string | |||
| port_payload: | |||
| context: | |||
There was a problem hiding this comment.
Suggested change
| context: | |
| port_context: |
| "properties": {}, | ||
| "censoredProperties": "{{.action.encryptedProperties}}" | ||
| } | ||
| "context": { |
There was a problem hiding this comment.
Suggested change
| "context": { | |
| "port_context": { |
| } | ||
| "dockerfile": "{{ .inputs.\"dockerfile\" }}", | ||
| "image_repo": "{{ .inputs.\"image_repo\" }}", | ||
| "context": { |
There was a problem hiding this comment.
Suggested change
| "context": { | |
| "port_context": { |
yairsimantov20
requested changes
May 23, 2024
pazhersh
requested changes
May 23, 2024
...elf-service-experiences/setup-backend/github-workflow/examples/AWS/create-an-ec2-instance.md
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the AWS GitHub guides with the v2 actions schema
Updated docs pages
Please also include the path for the updated docs