Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Multisig calls linked to a proxy account #11412

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ap211unitech
Copy link
Contributor

📝 Description

The current polkadot-js explorer has a bug where MultiSig calls fail to execute properly under specific conditions.

🤔 Steps to Reproduce

  1. Use a multisig account that also has an associated proxy account.
  2. Attempt to perform a transaction without using the proxy (i.e., select "Don't use a proxy call for this call").
  3. The UI gets stuck on the loading icon over the "Sign and Submit" button, making it unresponsive.
  4. The only workaround previously was to remove the proxy account from the explorer.

✅ Fix Implemented

  • Identified and resolved the root cause of the issue, ensuring proper handling of multisig transactions regardless of proxy usage.
  • Updated transaction submission logic to prevent UI from freezing.
  • Ensured that the "Sign and Submit" button remains functional in all cases.

🔥 Testing

  • Conducted thorough testing covering all possible cases to prevent recurrence of this issue.
  • Verified successful execution of MultiSig transactions with and without an associated proxy account.
  • Ensured the UI remains responsive and functional under all conditions.
  • This fix enhances the reliability of MultiSig transactions within polkadot-js explorer.
  • Users are no longer required to remove the proxy account as a workaround.

Proxy exists but not using proxy for signing

Screen.Recording.2025-03-21.at.15.10.34.mov

Using Proxy for signing

Screen.Recording.2025-03-21.at.15.13.29.mov

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multisig calls fail when linked to a proxy account. Unable to execute multisig call
2 participants