Feedback/#11253 #11304
Open
Feedback/#11253 #11304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ap211unitech
reviewed
Mar 6, 2025
| @@ -267,7 +267,7 @@ export const getSaleParameters = ( | |||
| coretime: 0, | |||
| relay: currentRegionInfo.end.blocks.relay + get.blocks.relay(config.regionLength) | |||
| }, | |||
| date: estimateTime(currentRegionInfo.end.ts + config.regionLength, get.blocks.relay(lastCommittedTimeslice), constants.relay), | |||
| date: formatDate(new Date(estimateTime(currentRegionInfo.end.ts + config.regionLength, get.blocks.relay(lastCommittedTimeslice), constants.relay) ?? '')), | |||
There was a problem hiding this comment.
It might end up giving Invalid Date or some incorrect info if
const estimated = estimateTime(currentRegionInfo.end.ts + config.regionLength, get.blocks.relay(lastCommittedTimeslice), constants.relay);if estimated returns null and the expression will eventually evaluate to formatDate(new Date('')).
However, If it is always guaranteed that estimatedTime will not return null, then we should update types accordingly.
| @@ -164,11 +164,11 @@ const getPhaseConfiguration = ( | |||
| const fixedPriceLengthTs = regionLength - interludeLengthTs - leadInLengthTs; | |||
| const fixedPriceEndTs = priceDiscoveryEndTs + fixedPriceLengthTs; | |||
| const get = createGet(constants); | |||
| const getDate = (ts: number) => estimateTime(ts, get.blocks.relay(lastCommittedTimeslice) ?? 0, constants.relay); | |||
| const getDate = (ts: number) => formatDate(new Date(estimateTime(ts, get.blocks.relay(lastCommittedTimeslice) ?? 0, constants.relay) ?? '')); | |||
There was a problem hiding this comment.
Same as #11304 (comment)
| const chainRegionEnd = (chainRecord.renewalStatus === ChainRenewalStatus.Renewed ? regionEnd : regionBegin); | ||
| const targetTimeslice = lease?.until || chainRegionEnd; | ||
| const showEstimates = !!targetTimeslice && Object.values(CoreTimeTypes)[chainRecord.type] !== CoreTimeTypes.Reservation; | ||
| const { coretimeInfo, get } = useCoretimeContext(); | ||
|
|
||
| const estimatedTime = showEstimates && get && coretimeInfo && | ||
| estimateTime(targetTimeslice, get.blocks.relay(lastCommittedTimeslice), coretimeInfo?.constants?.relay); | ||
| formatDate(new Date(estimateTime(targetTimeslice, get.blocks.relay(lastCommittedTimeslice), coretimeInfo?.constants?.relay) ?? '')); |
There was a problem hiding this comment.
Same as #11304 (comment)
| const currentRegionStart = useMemo(() => coretimeInfo ? coretimeInfo.salesInfo.regionEnd - coretimeInfo?.config.regionLength * 2 : 0, [coretimeInfo]); | ||
|
|
||
| const saleStartDate = useMemo(() => { | ||
| return get && coretimeInfo && formatDate(new Date(estimateTime(currentRegionStart, get.blocks.relay(coretimeInfo?.status?.lastTimeslice), coretimeInfo.constants.relay) ?? ''), true); |
There was a problem hiding this comment.
Same as #11304 (comment)
| }, [currentRegionStart, coretimeInfo, get]); | ||
|
|
||
| const saleEndDate = useMemo(() => { | ||
| return get && coretimeInfo && formatDate(new Date(estimateTime(currentRegionEnd, get.blocks.relay(coretimeInfo?.status?.lastTimeslice), coretimeInfo.constants.relay) ?? ''), true); |
There was a problem hiding this comment.
Same as #11304 (comment)
| @@ -46,154 +46,62 @@ const TableCol = ({ header, | |||
| ); | |||
|
|
|||
| function WorkInfoRow ({ data }: { data: InfoRow }): React.ReactElement { | |||
| if (!data.task) { | |||
| if (!data.task || data.type === undefined) { | |||
There was a problem hiding this comment.
We can say it just !data.type.
There was a problem hiding this comment.
data.type is an enum, hence it starts from 0 :) Actually I just realized this check is due to a switch later down the file, that is removed now, so I will remove this too.
export enum CoreTimeTypes {
'Reservation',
'Lease',
'Bulk Coretime',
'On Demand'
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing feedback from #11253 and a few points from #11262 (comment)
changes
to reproduce:
minor code changes