Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable metadata update to the extension on initialization #10827

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+27 −2
Open

feat: enable metadata update to the extension on initialization #10827

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
db45a03
changed extension metadata update to work on initialization
bee344 Aug 13, 2024
e7e2b30
Merge branch 'master' into anp-update-meta-on-init
bee344 Aug 13, 2024
4cca30e
restored metadata field in settings page
bee344 Aug 26, 2024
916be28
readded extension counter
bee344 Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
readded extension counter
  • Loading branch information
@bee344
bee344 committed Aug 26, 2024
commit 916be28a90ef0bab979abae4e1603bac6a7b6a03
4 changes: 3 additions & 1 deletion packages/page-settings/src/index.tsx
View file
Original file line number Diff line number Diff line change
@@ -21,6 +21,7 @@ export { useCounter };
function SettingsApp ({ basePath, onStatusChange }: Props): React.ReactElement<Props> {
const { t } = useTranslation();
const { api, isApiConnected, isApiReady, isDevelopment } = useApi();
const numExtensions = useCounter();

const items = useMemo(() => [
{
@@ -29,6 +30,7 @@ function SettingsApp ({ basePath, onStatusChange }: Props): React.ReactElement<P
text: t('General')
},
{
count: numExtensions,
name: 'metadata',
text: t('Metadata')
},
@@ -40,7 +42,7 @@ function SettingsApp ({ basePath, onStatusChange }: Props): React.ReactElement<P
name: 'i18n',
text: t('Translate')
}
], [t]);
], [numExtensions, t]);

const hidden = useMemo(
() => (isApiConnected && isApiReady)