Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Interpolatable to PositionList #120

Merged
merged 2 commits into from
May 21, 2024

Conversation

Stoops-ML
Copy link
Collaborator

  • Add Interpolatable base class to PositionList
  • Add test_positionlist_has_given_epoch

This allows PositionList to have an epoch etc as defined in Interpolatable.

Although PositionList on czml-writer specifically states that it is not interpolatable and does not include an epoch property, the path example on Cesium sandcastle provides an epoch property to the positions input (PositionList type). Seems to me that the documentation is incorrect here.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.22%. Comparing base (6f98435) to head (d212d90).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #120   +/-   ##
=======================================
  Coverage   99.22%   99.22%           
=======================================
  Files          12       12           
  Lines         774      774           
=======================================
  Hits          768      768           
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@astrojuanlu astrojuanlu merged commit 0477d4a into poliastro:main May 21, 2024
5 checks passed
@Stoops-ML Stoops-ML deleted the epoch_positionlist branch May 21, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants