[Application] feat: Add past delegation proofs

[red-0ne]

Summary

This PR adds support for old delegations verification by:

• Update Application proto to add undelegations map
• Adding a map of session end block heights to undelegations updated at undelegation time
• EndBlocker procedure that prunes old delegations past a retention time
• Pass in target block height to the ring client to generate the right gateway list at the provided block height
• Fix ring cache invalidation
• Fix the block hash used to generate the proof
• Fix account querier returning account with nil pub keys (accounts created at genesis time)
• Remove unused pubkey client code

1129 LOC out of 1314 are autogenerated pulsar code

Issue

• [Rings] Wait for redelegation grace periods to elapse before updating rings #476

Type of change

Select one or more:

• New feature, functionality or library
• Bug fix
• Code health or cleanup
• Documentation
• Other (specify)

Testing

Documentation changes (only if making doc changes)

• make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

• Unit Tests: make go_develop_and_test
• LocalNet E2E Tests: make test_e2e
• See quickstart guide for instructions

PR Testing (only if making code changes)

• DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
  • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
  • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
  • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

• I have tested my changes using the available tooling
• I have commented my code
• I have performed a self-review of my own code; both comments & source code
• I create and reference any new tickets, if applicable
• I have left TODOs throughout the codebase, if applicable

[Olshansk]

@red-0ne Confirming that this is not ready for initial review yet. Right?

[red-0ne]

@red-0ne Confirming that this is not ready for initial review yet. Right?

It is, just lacking E2E tests from the previous PR to be ported to this one

[Olshansk]

@red-0ne Please do the following:

1. See my comments. Even if they're outdated (based on code), PTAL at all of them
2. Review my commit in 82abcc8 (#518). Note the comments I made and the var changes I made.
3. Let's make the same changes as in (2) everywhere across the PR
4. Please respond to my comments in (1)
5. Re-request the review (even if it's still not complete) once I can start taking a look at what we have.

Other than that, love how much simpler this is!

[Olshansk]

Do we need to take grace period into account here?

[red-0ne]

Grace period as a special block count/height interval, should not be taken into account.

Getting the delegatee gateway addresses when in a session's grace period effectively involves looking past SessionGracePeriod number of sessions, so all it needs is that the pending undelegations are not pruned which is ensured by GetNumBlocksUndelegationRetention.

[Olshansk]

Does this implicitly assume that GetNumBlocksUndelegationRetention > SessionGracePeriod?

[red-0ne]

Yes, pruning is guarenteed to be >= SessionGracePeriod

func GetNumBlocksUndelegationRetention() int64 {
	return sessionkeeper.GetSessionGracePeriodBlockCount() +
		(sessionkeeper.NumBlocksPerSession * NumSessionsAppToGatewayUndelegationRetention)
}

[bryanchriswhite]

Nice one @red-0ne! 😎

I have to take a break on this for now but I'm almost to the end:

Great comments! 💪

[Olshansk]

Please see my last two comments but pre-emtively approving.

[bryanchriswhite]

💯

[github-actions]

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.