Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Code Health] chore: cleanup localnet testutils #515

Merged
merged 8 commits into from
May 8, 2024

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented May 3, 2024

Summary

  • Exclude Jetbrains IDE dotfiles (.idea/) & reviewdog.yml from make todo_this_commit
  • Simplify localnet testutil; remove unused/unnecessary dependency injected variables
  • Add godoc comments for global test variables

Issue

Observations made while using make todo_this_commit.

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

Documentation changes (only if making doc changes)

  • make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • See quickstart guide for instructions

PR Testing (only if making code changes)

  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
    • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
    • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
    • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite self-assigned this May 3, 2024
@bryanchriswhite bryanchriswhite added the code health Cleans up some code label May 3, 2024
Makefile Show resolved Hide resolved
@bryanchriswhite bryanchriswhite changed the title Chore/cleanup localnet testutils [Code Health] chore: cleanup localnet testutils May 3, 2024
Copy link

github-actions bot commented May 3, 2024

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. If you just created a pull request, you might need to push another commit to produce a container image DevNet can utilize to spin up infrastructure. You can use make trigger_ci to push an empty commit.

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels May 3, 2024
@bryanchriswhite bryanchriswhite force-pushed the chore/cleanup-localnet-testutils branch from c5dc13a to 48921fa Compare May 6, 2024 08:37
@bryanchriswhite bryanchriswhite force-pushed the chore/cleanup-localnet-testutils branch from f65ee3d to 34b4667 Compare May 7, 2024 10:42
@bryanchriswhite bryanchriswhite marked this pull request as ready for review May 7, 2024 10:57
@bryanchriswhite bryanchriswhite merged commit f488165 into main May 8, 2024
8 of 9 checks passed
@bryanchriswhite bryanchriswhite deleted the chore/cleanup-localnet-testutils branch May 8, 2024 18:06
bryanchriswhite added a commit that referenced this pull request May 8, 2024
* pokt/main:
  [Code Health] chore: cleanup localnet testutils (#515)
  Zero retryLimit Support in ReplayClient (#442)
  [LocalNet] Add infrastructure to run LLM inference (#508)
  [LocalNet] Documentation for MVT/LocalNet (#488)
  [GATEWAY] Makefile target added to send relays to grove gateway (#487)
  Update README
  [CI] Add GATEWAY_URL envar for e2e tests (#506)
  [Tooling] Add gateway stake/unstake/ logs (#503)
bryanchriswhite added a commit that referenced this pull request May 10, 2024
…cept

* pokt/main:
  Reply to red0ne's comments's in https://github.com/pokt-network/poktroll/pull/501\#pullrequestreview-2047120225
  [Docs] Added QuickStart video (#522)
  [Genesis Config] Set MaxValidators to 1 (#520)
  [Docs] Update `Quickstart` guide to onboard new devs (#501)
  [Code Health] chore: cleanup localnet testutils (#515)
  Zero retryLimit Support in ReplayClient (#442)
@bryanchriswhite bryanchriswhite removed push-image CI related - pushes images to ghcr.io devnet-test-e2e labels May 16, 2024
@github-actions github-actions bot removed the devnet label May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health Cleans up some code
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants