Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][DELETE ME] Example Test for #486 #514

Conversation

Olshansk
Copy link
Member

@Olshansk Olshansk commented May 3, 2024

If you run

go test -v -count=1 ./temp/...

It outputs

{"messages":[{"@type":"/cosmos.auth.v1beta1.MsgUpdateParams","authority":"cosmos1...","params":{"max_memo_characters":"100","tx_sig_limit":"0","tx_size_cost_per_byte":"0","sig_verify_cost_ed25519":"0","sig_verify_cost_secp256k1":"0"}}],"memo":"","timeout_height":"0","extension_options":[],"non_critical_extension_options":[]}

Copy link

gitguardian bot commented May 3, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@Olshansk Olshansk changed the base branch from main to issues/322/proof-of-concept May 3, 2024 03:03
@Olshansk Olshansk marked this pull request as draft May 3, 2024 03:03
@bryanchriswhite
Copy link
Contributor

Thanks @Olshansk! I did not realize that tx.TxBody was a proto.Message. Good lookin' out! 👊😎

I've incorporated the learning from this into #486. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants