[Protocol] Centralized Proof & Tokenomics param updating

.github/workflows-helpers/run-e2e-test-job-template.yaml

@@ -11,44 +11,52 @@ spec:
  pokt.network/purpose: e2e-tests
  spec:
  containers:
- - name: e2e-tests
- image: ghcr.io/pokt-network/poktrolld:${IMAGE_TAG}
- command: ["/bin/sh"]
- args:
- - "-c"
- - |
- poktrolld q gateway list-gateway --node=$POCKET_NODE && \
- poktrolld q application list-application --node=$POCKET_NODE && \
- poktrolld q supplier list-supplier --node=$POCKET_NODE && \
- make acc_initialize_pubkeys && \
- go test -v ./e2e/tests/... -tags=e2e
- env:
- - name: POCKET_NODE
- value: tcp://${NAMESPACE}-validator-poktrolld:36657
- - name: VALIDATOR_RPC_ENDPOINT
- value: ${NAMESPACE}-validator-poktrolld:36657
- - name: E2E_DEBUG_OUTPUT
- value: "false" # Flip to true to see the command and result of the execution
- - name: POKTROLLD_HOME
- value: /root/.poktroll
- - name: APPGATE_SERVER_URL
- value: http://${NAMESPACE}-appgate-server:80
- - name: GATEWAY_URL
- value: http://${NAMESPACE}-gateway:80
- volumeMounts:
- - mountPath: /root/.poktroll/keyring-test/
- name: keys-volume
- - mountPath: /root/.poktroll/config/
- name: configs-volume
+ - name: e2e-tests
+ image: ghcr.io/pokt-network/poktrolld:${IMAGE_TAG}
+ command: ["/bin/sh"]
+ args:
+ - "-c"
+ - |
+ # Copy files from the secret to the writable directory
+ cp -Lr /tmp/keys/* /root/.poktroll/keyring-test/ && \
+ echo "Listing /root/.poktroll/keyring-test/ after copying:"
+ ls -l /root/.poktroll/keyring-test/ && \
+ poktrolld q gateway list-gateway --node=$POCKET_NODE && \
+ poktrolld q application list-application --node=$POCKET_NODE && \
+ poktrolld q supplier list-supplier --node=$POCKET_NODE && \
+ make acc_initialize_pubkeys && \
+ go test -v ./e2e/tests/... -tags=e2e
+ env:
+ - name: POCKET_NODE
+ value: tcp://${NAMESPACE}-validator-poktrolld:36657
+ - name: VALIDATOR_RPC_ENDPOINT
+ value: ${NAMESPACE}-validator-poktrolld:36657
+ - name: E2E_DEBUG_OUTPUT
+ value: "false" # Flip to true to see the command and result of the execution
+ - name: POKTROLLD_HOME
+ value: /root/.poktroll
+ - name: APPGATE_SERVER_URL
+ value: http://${NAMESPACE}-appgate-server:80
+ - name: GATEWAY_URL
+ value: http://${NAMESPACE}-gateway:80
+ volumeMounts:
+ - mountPath: /root/.poktroll/keyring-test/
+ name: writable-keys-volume
+ - mountPath: /root/.poktroll/config/
+ name: configs-volume
+ - mountPath: /tmp/keys
+ name: non-writable-keys-volume
+ readOnly: true
  restartPolicy: Never
  volumes:
- - secret:
- defaultMode: 420
- secretName: keys-${IMAGE_TAG}
- name: keys-volume
- - configMap:
- defaultMode: 420
- name: configs-${IMAGE_TAG}
- name: configs-volume
+ - name: writable-keys-volume
+ emptyDir: {}
+ - name: non-writable-keys-volume
+ secret:
+ secretName: keys-${IMAGE_TAG}
+ - configMap:
+ defaultMode: 420
+ name: configs-${IMAGE_TAG}
+ name: configs-volume
  serviceAccountName: default
  backoffLimit: 0

.github/workflows/reviewdog.yml

@@ -24,6 +24,21 @@ jobs:
  fail_on_error: true
  pattern: TODO_IN_THIS_
 
+ # Prevent the use of `sed` in helper scripts. This ensures compatibility across
+ # Darwin and Linux systems.
+ check_sed:
+ name: Check sed
+ runs-on: ubuntu-latest
+ steps:
+ - uses: actions/checkout@v4
+ - uses: pokt-network/action-fail-on-found@v1
+ with:
+ github_token: ${{ secrets.github_token }}
+ reporter: github-pr-review
+ level: error
+ fail_on_error: true
+ pattern: sed -i .*
+
  # Ensure that we are using polylog (via logger.) instead of the golang's stdlib
  # log package.
  check_stdlog_in_off_chain_package:

Dockerfile.dev

@@ -6,7 +6,7 @@ FROM golang:1.22.2 as base
 RUN apt update && \
  apt-get install -y \
  ca-certificates net-tools kubernetes-client \
- curl jq make vim less dnsutils
+ curl jq yq make vim less dnsutils
 
 # enable faster module downloading.
 ENV GOPROXY https://proxy.golang.org
@@ -17,7 +17,11 @@ WORKDIR /poktroll
 
 RUN mv /poktroll/bin/ignite /usr/bin/ && mv /poktroll/bin/poktrolld /usr/bin/
 
-RUN ignite chain init --skip-proto
+# These are helpful for testing locally:
+# RUN mv bin/poktrolld /usr/bin/
+# RUN mv bin/ignite /usr/bin/
+
+RUN make localnet_regenesis
 
 # TODO_TECHDEBT(@okdas): Ports are not documented as they will soon be changed with a document to follow
 EXPOSE 8545

Makefile

@@ -20,6 +20,11 @@ APPLICATION_MODULE_ADDRESS = pokt1rl3gjgzexmplmds3tq3r3yk84zlwdl6djzgsvm
 SUPPLIER_MODULE_ADDRESS = pokt1j40dzzmn6cn9kxku7a5tjnud6hv37vesr5ccaa
 GATEWAY_MODULE_ADDRESS = pokt1f6j7u6875p2cvyrgjr0d2uecyzah0kget9vlpl
 SERVICE_MODULE_ADDRESS = pokt1nhmtqf4gcmpxu0p6e53hpgtwj0llmsqpxtumcf
+GOV_ADDRESS = pokt10d07y265gmmuvt4z0w9aw880jnsr700j8yv32t
+# PNF acts on behalf of the DAO and who AUTHZ must delegate to
+PNF_ADDRESS = pokt1eeeksh2tvkh7wzmfrljnhw4wrhs55lcuvmekkw
+
+MODULES := application gateway pocket service session supplier proof tokenomics
 
 BRANCH := $(shell git rev-parse --abbrev-ref HEAD)
 COMMIT := $(shell git log -1 --format='%H')
@@ -304,10 +309,13 @@ localnet_down: ## Delete resources created by localnet
 localnet_regenesis: check_yq acc_initialize_pubkeys_warn_message ## Regenerate the localnet genesis file
 # NOTE: intentionally not using --home <dir> flag to avoid overwriting the test keyring
  @echo "Initializing chain..."
- @set -e ;\
- ignite chain init --skip-proto ;\
- cp -r ${HOME}/.poktroll/keyring-test $(POKTROLLD_HOME) ;\
- cp -r ${HOME}/.poktroll/config $(POKTROLLD_HOME)/ ;\
+ @set -e
+ @ignite chain init --skip-proto
+ AUTH_CONTENT=$$(cat ./tools/scripts/authz/dao_genesis_authorizations.json | jq -r tostring); \
+ $(SED) -i -E 's!^(\s*)"authorization": (\[\]|null)!\1"authorization": '$$AUTH_CONTENT'!' ${HOME}/.poktroll/config/genesis.json;
+
+ @cp -r ${HOME}/.poktroll/keyring-test $(POKTROLLD_HOME)
+ @cp -r ${HOME}/.poktroll/config $(POKTROLLD_HOME)/
 
 .PHONY: send_relay
 send_relay:
@@ -726,11 +734,10 @@ acc_balance_total_supply: ## Query the total supply of the network
 .PHONY: acc_initialize_pubkeys
 acc_initialize_pubkeys: ## Make sure the account keeper has public keys for all available accounts
  $(eval ADDRESSES=$(shell make -s ignite_acc_list | grep pokt | awk '{printf "%s ", $$2}' | sed 's/.$$//'))
- $(eval PNF_ADDR=pokt1eeeksh2tvkh7wzmfrljnhw4wrhs55lcuvmekkw)
  $(foreach addr, $(ADDRESSES),\
  echo $(addr);\
  poktrolld tx bank send \
- $(addr) $(PNF_ADDR) 1000upokt \
+ $(addr) $(PNF_ADDRESS) 1000upokt \
  --yes \
  --home=$(POKTROLLD_HOME) \
  --node $(POCKET_NODE) \
@@ -790,15 +797,27 @@ claim_list_session: ## List all the claims ending at a specific session (specifi
 ### Params ###
 ##############
 
-MODULES := application gateway pocket service session supplier tokenomics
+# TODO_CONSIDERATION: additional factoring (e.g. POKTROLLD_FLAGS).
+PARAM_FLAGS = --home=$(POKTROLLD_HOME) --keyring-backend test --from $(PNF_ADDRESS) --node $(POCKET_NODE)
+
+.PHONY: update_tokenomics_params_all
+params_update_tokenomics_all: ## Update the tokenomics module params
+ poktrolld tx authz exec ./tools/scripts/params/tokenomics_all.json $(PARAM_FLAGS)
+
+.PHONY: params_update_tokenomics_compute_units_to_tokens_multiplier
+params_update_tokenomics_compute_units_to_tokens_multiplier: ## Update the tokenomics module params
+ poktrolld tx authz exec ./tools/scripts/params/tokenomics_compute_units_to_tokens_multiplier.json $(PARAM_FLAGS)
+
+.PHONY: params_update_proof_all
+params_update_proof_all: ## Update the proof module params
+ poktrolld tx authz exec ./tools/scripts/params/proof_all.json $(PARAM_FLAGS)
 
-# TODO_IMPROVE(#322): Improve once we decide how to handle parameter updates
-.PHONY: update_tokenomics_params
-update_tokenomics_params: ## Update the tokenomics module params
- poktrolld --home=$(POKTROLLD_HOME) tx tokenomics update-params 43 --keyring-backend test --from pnf --node $(POCKET_NODE) --chain-id $(CHAIN_ID)
+.PHONY: params_update_proof_min_relay_difficulty_bits
+params_update_proof_min_relay_difficulty_bits: ## Update the proof module params
+ poktrolld tx authz exec ./tools/scripts/params/proof_min_relay_difficulty_bits.json $(PARAM_FLAGS)
 
-.PHONY: query_all_params
-query_all_params: check_jq ## Query the params from all available modules
+.PHONY: params_query_all
+params_query_all: check_jq ## Query the params from all available modules
  @for module in $(MODULES); do \
  echo "~~~ Querying $$module module params ~~~"; \
  poktrolld query $$module params --node $(POCKET_NODE) --output json | jq; \