-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zero retryLimit Support in ReplayClient #442
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
d7621fc
Support infinite connection attempt retries
ezeike 4cb108c
Added TODO
ezeike efca1f2
Removed panics in replay_client
ezeike bc721da
refactor: factor out connection retry limit
bryanchriswhite 6f8153b
fix: default conn retry limit & simplify config usage
bryanchriswhite 5c8f542
Fix in OnError and test update
ezeike 3b3b7cb
retry test test fixes
ezeike 983f58d
Removed panics in replay_client
ezeike def63d9
refactor: factor out connection retry limit
bryanchriswhite c397674
fix: default conn retry limit & simplify config usage
bryanchriswhite 9fe81eb
Fix in OnError and test update
ezeike 0efe669
Update pkg/client/events/replay_client.go
Olshansk 5b2b59b
Variable rename
ezeike 094f8bf
Empty commit
ezeike 579c344
Empty commit
ezeike e382fe5
Update pkg/client/interface.go
ezeike c37e36c
Update pkg/retry/retry_test.go
ezeike f91721c
Update pkg/retry/retry_test.go
ezeike 108303a
[Config] feat: Simplify relay miner config (#477)
red-0ne 6680149
[Tooling] Add claim/proof/settlement dashboard & link (#479)
bryanchriswhite 4ccf0ca
Merge remote-tracking branch 'pokt/main' into zero-retrylimit-replayc…
bryanchriswhite d991a18
lint fix
ezeike 09f5fd7
Type coercion update
ezeike 89076c0
fix: tests
bryanchriswhite 008842e
fix: tests
bryanchriswhite 9a68de3
Merge branch 'main' into zero-retrylimit-replayclient
Olshansk 4bf968a
Godoc comment update
ezeike 6209183
Merge branch 'main' into zero-retrylimit-replayclient
bryanchriswhite 0d607ae
Empty commit
bryanchriswhite 47eeadb
Merge branch 'main' into zero-retrylimit-replayclient
Olshansk 1921dd8
Empty commit
bryanchriswhite 0693ca1
Empty commit
Olshansk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package block | ||
|
||
import "github.com/pokt-network/poktroll/pkg/client" | ||
|
||
// WithConnRetryLimit returns an option function which sets the number | ||
// of times the underlying replay client should retry in the event that it encounters | ||
// an error or its connection is interrupted. | ||
// If connRetryLimit is < 0, it will retry indefinitely. | ||
func WithConnRetryLimit(limit int) client.BlockClientOption { | ||
return func(client client.BlockClient) { | ||
client.(*blockReplayClient).connRetryLimit = limit | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,13 @@ | ||
package delegation | ||
|
||
import "github.com/pokt-network/poktroll/pkg/client" | ||
|
||
// WithConnRetryLimit returns an option function which sets the number | ||
// of times the underlying replay client should retry in the event that it encounters | ||
// an error or its connection is interrupted. | ||
// If connRetryLimit is < 0, it will retry indefinitely. | ||
func WithConnRetryLimit(limit int) client.DelegationClientOption { | ||
return func(client client.DelegationClient) { | ||
client.(*delegationClient).connRetryLimit = limit | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bryanchriswhite When you work on updating one governance parameter at a time, taking this pattern into consideration will be critical!