[Testing, Tooling] chore: in-memory network interface & config types #289

bryanchriswhite · 2023-12-21T18:46:36Z

Summary

Human Summary

Regenerates pre-generated accounts with proper bech32 prefix.
Adds InMemoryCosmosNetwork interface type.
Adds InMemoryNetworkConfig concrete type.

Issue

Type of change

Select one or more:

Testing

Run all unit tests: make go_develop_and_test
Run E2E tests locally: make test_e2e
Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

I have tested my changes using the available tooling
I have performed a self-review of my own code
I have commented my code, updated documentation and left TODOs throughout the codebase

Co-authored-by: harry <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]>

Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: harry <[email protected]>

…im-proof * pokt/main: Fix bug introduced by #252 where genesis file was no longer being copied to the right location [Docs] Introduce Docusaurus documentation (#252) [Cleanup] Centralzie websocket url -> endpoint changes (#272) refactor: `NewMinedRelay` to shared testutil (#262) fix: PR template typo 2 (#269) [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253) [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)

…or/supplier-keys * issues/141/refactor/claim-proof: chore: review feedback improvements chore: review feedback improvements Fix bug introduced by #252 where genesis file was no longer being copied to the right location [Docs] Introduce Docusaurus documentation (#252) [Cleanup] Centralzie websocket url -> endpoint changes (#272) refactor: `NewMinedRelay` to shared testutil (#262) fix: PR template typo 2 (#269) [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253) [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)

Co-authored-by: Daniel Olshansky <[email protected]>

…ctor/supplier-errors * issues/141/refactor/supplier-keys: chore: review feedback improvements chore: review feedback improvements Fix bug introduced by #252 where genesis file was no longer being copied to the right location [Docs] Introduce Docusaurus documentation (#252) [Cleanup] Centralzie websocket url -> endpoint changes (#272) refactor: `NewMinedRelay` to shared testutil (#262) fix: PR template typo 2 (#269) [Testing] Unit tests, E2E tests, logging and other Fixes / "Touchups" (#253) [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261)

This reverts commit af531b0.

testutil/network/config.go

h5law · 2024-01-09T13:50:42Z

x/session/keeper/session_hydrator.go

- sh.session.SessionNumber = int64(sh.blockHeight / NumBlocksPerSession)
+ sh.session.SessionNumber = sh.blockHeight / NumBlocksPerSession
+
+ // TODO_BLOCKER: SessionStartBlockHeight should be aligned to NumBlocksPerSession.


h5law · 2024-01-09T13:53:26Z

testutil/network/config.go

+ encoding = app.MakeEncodingConfig()
+ chainID = "chain-" + rand.NewRand().Str(6)
+ )
+ return network.Config{


I think the answer to #303 is in this struct somewhere.

h5law · 2024-01-09T13:54:18Z

@bryanchriswhite forgot to leave a a comment pre-emptive approving while u fix them as they are minor

testutil/network/interface.go

Olshansk · 2024-01-10T00:31:22Z

testutil/network/config.go

+func (cfg *InMemoryNetworkConfig) GetNumKeyringAccounts(t *testing.T) int {
+ t.Helper()
+
+ return cfg.NumGateways + cfg.NumSuppliers + cfg.GetNumApplications(t)


Re assumption w.r.t #GetNumKeyringAccounts. 👍 and doesn't even need a comment

Regarding #GetNumApplications(), I think we should add a comment above the return w/ something like "NumApplications is intentionally a computed field" and potentially link to this comment.

Olshansk

Left one outstanding comment but otherwise lgtm!

Co-authored-by: Daniel Olshansky <[email protected]>

…or/supplier-keys

…ctor/supplier-errors

…or/supplier-keys

…ctor/supplier-errors

Co-authored-by: h5law <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]>

…ep/in-memory-network

…or/supplier-keys

…ctor/supplier-errors

…ep/in-memory-network

…im-proof * pokt/main: [Supplier] refactor: claim & proof protobufs + (#263)

…or/supplier-keys

…plier-keys * pokt/main: [Supplier] refactor: supplier module keys (#264)

…ctor/supplier-errors * issues/141/refactor/supplier-keys: [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263)

…plier-errors * pokt/main: [Supplier] refactor: supplier module errors (#265)

…ep/in-memory-network * issues/141/refactor/supplier-errors: [Supplier] refactor: supplier module errors (#265) [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263)

…ry-network * pokt/main: [Testing, Tooling] chore: in-memory network interface & config types (#289)

…/in-memory-network * issues/141/prep/in-memory-network: [Testing, Tooling] chore: in-memory network interface & config types (#289) trigger CI [Supplier] refactor: supplier module errors (#265) [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263) chore: review feedback improvements [Configs] feat: Add staking config parser of gateway staking (#302) chore: review feedback improvements fix: usage raw string literal chore: review feedback improvements [RingCache] Invalidate Cache On Redelegation Events (#239)

…ctor/in-memory-network * issues/141/feat/in-memory-network: chore: review feedback improvements feat: update SMT to v0.9.2 (#311) fix: linter errors fixup! chore: review feedback improvements chore: review feedback improvements chore: review feedback improvements [Testing, Tooling] chore: in-memory network interface & config types (#289) trigger CI [Supplier] refactor: supplier module errors (#265) [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263) chore: review feedback improvements [Configs] feat: Add staking config parser of gateway staking (#302) chore: review feedback improvements fix: usage raw string literal chore: review feedback improvements [RingCache] Invalidate Cache On Redelegation Events (#239)

bryanchriswhite added 7 commits December 13, 2023 14:56

refactor: NewMinedRelay to shared testutil

4bcd8de

refactor: claim & proof protobuf types

673911c

refactor: rename supplier keeper UpsertClaim & UpsertProof

fd55896

refactor: misc. claim-side improvements

43cbf0e

chore: add TODOs

ef3cd99

refactor: supplier module keys

f509fbf

refactor: supplier module errors

6817364

bryanchriswhite added testing Test (or test utils) additions, fixes, improvements or other tooling Tooling - CLI, scripts, helpers, off-chain, etc... labels Dec 21, 2023

bryanchriswhite added this to the Shannon TestNet milestone Dec 21, 2023

bryanchriswhite self-assigned this Dec 21, 2023

This was referenced Dec 21, 2023

[Testing, Tooling] feat: implement in-memory networks #290

Closed

[Testing, Tooling] refactor: in-memory network usage #285

Merged

bryanchriswhite changed the title ~~[Testing, Tooling] feat: add in memory network interface & config types~~ [Testing, Tooling] chore: in-memory network interface & config types Dec 21, 2023

bryanchriswhite force-pushed the issues/141/prep/in-memory-network branch 2 times, most recently from 5414460 to e3c3f8c Compare December 21, 2023 20:10

bryanchriswhite and others added 12 commits December 22, 2023 14:36

chore: review feedback improvements

6e60952

Co-authored-by: harry <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]>

chore: review feedback improvements

edc4e41

Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: harry <[email protected]>

chore: review feedback improvements

dfb067d

Co-authored-by: Daniel Olshansky <[email protected]>

fix: pre-generated keyring accounts

b82e49a

fix: session hydrator

2d52838

feat: add InMemoryCosmosNetwork interface

6a9d6ec

chore: add InMemoryNetworkConfig

5566e5c

chore: add TODO comment

923907b

Revert "fix: pre-generated keyring accounts"

8b57b22

This reverts commit af531b0.

bryanchriswhite force-pushed the issues/141/prep/in-memory-network branch from e3c3f8c to 8b57b22 Compare December 22, 2023 14:12

bryanchriswhite mentioned this pull request Dec 22, 2023

[Supplier] refactor: claim & proof protobufs + #263

Merged

11 tasks

h5law approved these changes Jan 9, 2024

View reviewed changes

Olshansk reviewed Jan 10, 2024

View reviewed changes

Olshansk approved these changes Jan 10, 2024

View reviewed changes

bryanchriswhite and others added 20 commits January 10, 2024 10:16

Merge branch 'main' into issues/141/refactor/claim-proof

5905d20

chore: review feedback improvements

4248b0b

Co-authored-by: Daniel Olshansky <[email protected]>

Merge branch 'issues/141/refactor/claim-proof' into issues/141/refact…

f064432

…or/supplier-keys

Merge branch 'issues/141/refactor/supplier-keys' into issues/141/refa…

7bacad9

…ctor/supplier-errors

fix: usage raw string literal

6d5826f

Merge branch 'issues/141/refactor/claim-proof' into issues/141/refact…

92970b9

…or/supplier-keys

Merge branch 'issues/141/refactor/supplier-keys' into issues/141/refa…

ab3fd1e

…ctor/supplier-errors

chore: review feedback improvements

a57273c

Co-authored-by: h5law <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]>

Merge branch 'issues/141/refactor/supplier-errors' into issues/141/pr…

8486a8c

…ep/in-memory-network

Merge branch 'main' into issues/141/refactor/claim-proof

53faaac

Merge branch 'issues/141/refactor/claim-proof' into issues/141/refact…

0ada011

…or/supplier-keys

Merge branch 'issues/141/refactor/supplier-keys' into issues/141/refa…

6df8994

…ctor/supplier-errors

chore: review feedback improvements

2f1232c

Merge branch 'issues/141/refactor/supplier-errors' into issues/141/pr…

bd60220

…ep/in-memory-network

Merge remote-tracking branch 'pokt/main' into issues/141/refactor/cla…

c648d4f

…im-proof * pokt/main: [Supplier] refactor: claim & proof protobufs + (#263)

Merge branch 'issues/141/refactor/claim-proof' into issues/141/refact…

dd53efc

…or/supplier-keys

Merge remote-tracking branch 'pokt/main' into issues/141/refactor/sup…

fea3d27

…plier-keys * pokt/main: [Supplier] refactor: supplier module keys (#264)

Merge branch 'issues/141/refactor/supplier-keys' into issues/141/refa…

c00e1b2

…ctor/supplier-errors * issues/141/refactor/supplier-keys: [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263)

Merge remote-tracking branch 'pokt/main' into issues/141/refactor/sup…

7d1b1e0

…plier-errors * pokt/main: [Supplier] refactor: supplier module errors (#265)

bryanchriswhite changed the base branch from issues/141/refactor/supplier-errors to main January 10, 2024 13:06

trigger CI

afbefe7

bryanchriswhite merged commit db80345 into main Jan 10, 2024
10 checks passed

bryanchriswhite added a commit that referenced this pull request Jan 10, 2024

Merge remote-tracking branch 'pokt/main' into issues/141/prep/in-memo…

6c35227

…ry-network * pokt/main: [Testing, Tooling] chore: in-memory network interface & config types (#289)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Testing, Tooling] chore: in-memory network interface & config types #289

[Testing, Tooling] chore: in-memory network interface & config types #289

bryanchriswhite commented Dec 21, 2023 •

edited

Loading

h5law Jan 9, 2024

h5law Jan 9, 2024

h5law commented Jan 9, 2024

Olshansk Jan 10, 2024

Olshansk left a comment

[Testing, Tooling] chore: in-memory network interface & config types #289

[Testing, Tooling] chore: in-memory network interface & config types #289

Conversation

bryanchriswhite commented Dec 21, 2023 • edited Loading

Summary

Human Summary

Issue

Type of change

Testing

Sanity Checklist

h5law Jan 9, 2024

Choose a reason for hiding this comment

h5law Jan 9, 2024

Choose a reason for hiding this comment

h5law commented Jan 9, 2024

Olshansk Jan 10, 2024

Choose a reason for hiding this comment

Olshansk left a comment

Choose a reason for hiding this comment

bryanchriswhite commented Dec 21, 2023 •

edited

Loading