-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Relayminer config documentation #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoud be g2g after a round of changes and cross-referencing #284, but am a big fan of the shape it's taking!
_Assuming that the on-chain endpoints 1 and 2 have different hosts_ | ||
|
||
```mermaid | ||
flowchart LR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started making a few edits to the chart so the yaml <-> protobuf
conversion is clearer. Might need a few more tweaks but lmk wyt
flowchart LR
subgraph "Supplier Actor (On-Chain)"
subgraph "SupplierServiceConfig (protobuf)"
subgraph svc1["Service1 (protobuf)"]
svc1Id[Service1.Id]
subgraph SupplierEndpoint
EP1[Endpoint1]
EP2[Endpoint2]
end
end
subgraph svc2[Service2]
svc2Id[Service2.Id]
end
end
end
subgraph "RelayMiner Operator (Off-Chain)"
subgraph "DevOps Operator Configs (yaml)"
subgraph svc1Config["Service1 Config (yaml)"]
svc1IdConfig[name=Service1.Id]-->svc1Id
subgraph Hosts
H1[Endpoint1.Host]-->EP1
H2[Endpoint2.Host]-->EP2
end
end
subgraph svc2Config[Service2 Config]
svc2IdConfig[Service2.Id]
end
end
end
svc2Config-->svc2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@red-0ne I didn't mean to suggest that I "finished" the diagram but just wanted to provide a starting point.
I want to get this PR in, so here's what I think we should do:
- With what we have, is
name
still relevant given that we renamed it toproxy_name
or was that a different name? - Merge in the what we have as "good enough" but remember to "update and improve" when something comes up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this but PTAL at the following before merging: #288 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…or/supplier-keys * issues/141/refactor/claim-proof: chore: add TODOs [Docs] Load Test #1 - Plan (#286) [Bug] Fix observable error logging (#298) [docs] Relayminer config documentation (#288) [Configs] Add foundation for RelayMiner operation configs. (#284) [SMT] Update to use SMT v0.8.2 (#297) [EventsReplayClient] Fix Replay Client Bugs (#267)
…ctor/supplier-errors * issues/141/refactor/supplier-keys: chore: add TODOs [Docs] Load Test #1 - Plan (#286) [Bug] Fix observable error logging (#298) [docs] Relayminer config documentation (#288) [Configs] Add foundation for RelayMiner operation configs. (#284) [SMT] Update to use SMT v0.8.2 (#297) [EventsReplayClient] Fix Replay Client Bugs (#267)
…ep/in-memory-network * issues/141/refactor/supplier-errors: chore: add TODOs [Docs] Load Test #1 - Plan (#286) [Bug] Fix observable error logging (#298) [docs] Relayminer config documentation (#288) [Configs] Add foundation for RelayMiner operation configs. (#284) [SMT] Update to use SMT v0.8.2 (#297) [EventsReplayClient] Fix Replay Client Bugs (#267)
…/in-memory-network * issues/141/prep/in-memory-network: chore: add #GetConfig() chore: rename InMemoryCosmosNetwork to InMemoryNetwork chore: update comment chore: review feedback improvements chore: add TODOs [Docs] Load Test #1 - Plan (#286) [Bug] Fix observable error logging (#298) [docs] Relayminer config documentation (#288) [Configs] Add foundation for RelayMiner operation configs. (#284) [SMT] Update to use SMT v0.8.2 (#297) [EventsReplayClient] Fix Replay Client Bugs (#267)
…ctor/in-memory-network * issues/141/feat/in-memory-network: chore: fix comment typo chore: post-merge refactor chore: fix comment chore: add #GetConfig() chore: rename InMemoryCosmosNetwork to InMemoryNetwork chore: update comment chore: review feedback improvements chore: add TODOs [Docs] Load Test #1 - Plan (#286) [Bug] Fix observable error logging (#298) [docs] Relayminer config documentation (#288) [Configs] Add foundation for RelayMiner operation configs. (#284) [SMT] Update to use SMT v0.8.2 (#297) [EventsReplayClient] Fix Replay Client Bugs (#267)
…refactor/proof-store-indices * issues/141/refactor/in-memory-network: chore: post-merge refactor chore: review feedback improvements chore: fix comment typo chore: post-merge refactor chore: fix comment chore: add #GetConfig() chore: rename InMemoryCosmosNetwork to InMemoryNetwork chore: update comment chore: review feedback improvements chore: add TODOs [Docs] Load Test #1 - Plan (#286) [Bug] Fix observable error logging (#298) [docs] Relayminer config documentation (#288) [Configs] Add foundation for RelayMiner operation configs. (#284) [SMT] Update to use SMT v0.8.2 (#297) [EventsReplayClient] Fix Replay Client Bugs (#267)
Summary
AI Summary
Summary generated by Reviewpad on 04 Jan 24 23:45 UTC
This pull request includes the addition of a new file, category.json. The added file contains a JSON object with the properties: "label" set to "Configs", "position" set to 5, and "link" set to an object with "type" as "generated-index" and "description" as "Poktroll Configs".
Issue
Type of change
Select one or more: