Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[On-chain, Testing] refactor: in-memory network testutils #273

Conversation

bryanchriswhite
Copy link
Contributor

Summary

Human Summary

WIP

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Run E2E tests locally: make test_e2e
  • Run E2E tests on DevNet: Add the devnet-test-e2e label to the PR. This is VERY expensive, only do it after all the reviews are complete.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@bryanchriswhite bryanchriswhite added testing Test (or test utils) additions, fixes, improvements or other on-chain On-chain business logic labels Dec 14, 2023
@bryanchriswhite bryanchriswhite added this to the Shannon TestNet milestone Dec 14, 2023
@bryanchriswhite bryanchriswhite self-assigned this Dec 14, 2023
@bryanchriswhite bryanchriswhite merged commit 278365b into issues/141/feat/proof-persistence Dec 19, 2023
@bryanchriswhite bryanchriswhite force-pushed the issues/141/refactor/in-memory-network branch from 76ef254 to 278365b Compare December 19, 2023 18:32
@bryanchriswhite
Copy link
Contributor Author

NOT ACTUALLY MERGED: re-opened as #285.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-chain On-chain business logic testing Test (or test utils) additions, fixes, improvements or other
Projects
Status: ✅ Done
1 participant