[Supplier] refactor: supplier module errors #265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanchriswhite
added
on-chain
10 tasks
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-keys
branch
from
d5492ed
to
3d97a36
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-errors
branch
from
a789bb3
to
7c961b5
Compare
8 tasks
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-keys
branch
from
3d97a36
to
cd0c4d7
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-errors
branch
2 times, most recently
from
9f31147
to
190b58b
Compare
bryanchriswhite
changed the title
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-keys
branch
from
cd0c4d7
to
f509fbf
Compare
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-errors
branch
from
190b58b
to
6ebd664
Compare
8 tasks
bryanchriswhite
force-pushed
the
issues/141/refactor/supplier-errors
branch
from
6ebd664
to
6817364
Compare
Olshansk
requested changes
Dec 20, 2023
| // NB: this is *NOT* a gRPC status error because the bech32 parse | ||
| // error occurs during request validation (i.e. client-side). | ||
| expectedErr: types.ErrSupplierInvalidAddress.Wrapf( | ||
| // TODO_CONSIDERATION: prefer using "%q" in error format strings |
There was a problem hiding this comment.
I think this is an awesome idea. Let's start doing this!
Might just be worth @mentioning protocol-dev on discord and we'll adopt it over time.
Co-authored-by: harry <[email protected]> Co-authored-by: Daniel Olshansky <[email protected]>
Co-authored-by: Daniel Olshansky <[email protected]> Co-authored-by: harry <[email protected]>
11 tasks
Olshansk
approved these changes
Jan 9, 2024
| @@ -9,7 +9,7 @@ import ( | |||
| // x/supplier module sentinel errors | |||
| var ( | |||
| ErrSupplierInvalidStake = sdkerrors.Register(ModuleName, 1, "invalid supplier stake") | |||
| ErrSupplierInvalidAddress = sdkerrors.Register(ModuleName, 2, "invalid supplier address") | |||
| ErrSupplierInvalidAddress = sdkerrors.Register(ModuleName, 2, "invalid address") | |||
There was a problem hiding this comment.
The intention behind this change is to avoid creating an additional supplier module error which represents an invalid application address. As we're already wrapping these errors with formatted messages (#Wrapf()), it seemed more appropriate to me to generalize the message here. Additionally, my understanding of the purpose of naming the errors after their modules was to easily signal which module an error came from.
Co-authored-by: Daniel Olshansky <[email protected]>
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. |
…ctor/supplier-errors
…ctor/supplier-errors
…ctor/supplier-errors
bryanchriswhite
removed
push-image
bryanchriswhite
changed the base branch from
issues/141/refactor/supplier-keys
to
main
bryanchriswhite
added a commit
that referenced
this pull request
Jan 10, 2024
…plier-errors * pokt/main: [Supplier] refactor: supplier module errors (#265)
bryanchriswhite
added a commit
that referenced
this pull request
Jan 10, 2024
…/in-memory-network * issues/141/prep/in-memory-network: [Testing, Tooling] chore: in-memory network interface & config types (#289) trigger CI [Supplier] refactor: supplier module errors (#265) [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263) chore: review feedback improvements [Configs] feat: Add staking config parser of gateway staking (#302) chore: review feedback improvements fix: usage raw string literal chore: review feedback improvements [RingCache] Invalidate Cache On Redelegation Events (#239)
bryanchriswhite
added a commit
that referenced
this pull request
Jan 12, 2024
…ctor/in-memory-network * issues/141/feat/in-memory-network: chore: review feedback improvements feat: update SMT to v0.9.2 (#311) fix: linter errors fixup! chore: review feedback improvements chore: review feedback improvements chore: review feedback improvements [Testing, Tooling] chore: in-memory network interface & config types (#289) trigger CI [Supplier] refactor: supplier module errors (#265) [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263) chore: review feedback improvements [Configs] feat: Add staking config parser of gateway staking (#302) chore: review feedback improvements fix: usage raw string literal chore: review feedback improvements [RingCache] Invalidate Cache On Redelegation Events (#239)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
Refactors supplier module error usage to be consistent with respect to:
It also makes "tighter" assertions about the error types/messages in failure test cases.
Issue
SubmitProofmessage handling #141Type of change
Select one or more:
Testing
make go_develop_and_testmake test_e2edevnet-test-e2elabel to the PR. This is VERY expensive, only do it after all the reviews are complete.Sanity Checklist