[RingCache] Invalidate Cache On Redelegation Events #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
h5law
added
off-chain
h5law
force-pushed
the
feat/invalidate-ring-cache
branch
from
a7bfec4
to
e8dad9e
Compare
Olshansk
requested changes
Dec 5, 2023
h5law
force-pushed
the
feat/invalidate-ring-cache
branch
from
e8dad9e
to
2132576
Compare
h5law
force-pushed
the
feat/invalidate-ring-cache
branch
from
0c40f96
to
5ca9322
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
h5law
force-pushed
the
feat/invalidate-ring-cache
branch
from
5ca9322
to
c673b90
Compare
h5law
force-pushed
the
feat/invalidate-ring-cache
branch
from
c673b90
to
b30b1a7
Compare
commit d621631 Author: Redouane Lakrache <[email protected]> Date: Wed Dec 13 16:24:34 2023 +0100 [SDK] feat: Have distinct JSON-RPC and gRPC urls (#261) * feat: Have distinct JSON-RPC and gRPC urls * chore: Trigger e2e tests * chore: Fix import groups commit 4e30e27 Author: Bryan White <[email protected]> Date: Wed Dec 13 14:28:36 2023 +0100 fix PR template testing checklist item (#268)
h5law
force-pushed
the
feat/invalidate-ring-cache
branch
from
3ec55be
to
ca04d32
Compare
|
@Olshansk I think this is good to go once e2e stuff is fixed I can add the label |
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. |
github-actions
bot
added
devnet
push-image
Olshansk
requested changes
Jan 3, 2024
Olshansk
requested changes
Jan 9, 2024
Olshansk
approved these changes
Jan 10, 2024
bryanchriswhite
added a commit
that referenced
this pull request
Jan 10, 2024
…/in-memory-network * issues/141/prep/in-memory-network: [Testing, Tooling] chore: in-memory network interface & config types (#289) trigger CI [Supplier] refactor: supplier module errors (#265) [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263) chore: review feedback improvements [Configs] feat: Add staking config parser of gateway staking (#302) chore: review feedback improvements fix: usage raw string literal chore: review feedback improvements [RingCache] Invalidate Cache On Redelegation Events (#239)
bryanchriswhite
added a commit
that referenced
this pull request
Jan 12, 2024
…ctor/in-memory-network * issues/141/feat/in-memory-network: chore: review feedback improvements feat: update SMT to v0.9.2 (#311) fix: linter errors fixup! chore: review feedback improvements chore: review feedback improvements chore: review feedback improvements [Testing, Tooling] chore: in-memory network interface & config types (#289) trigger CI [Supplier] refactor: supplier module errors (#265) [Supplier] refactor: supplier module keys (#264) [Supplier] refactor: claim & proof protobufs + (#263) chore: review feedback improvements [Configs] feat: Add staking config parser of gateway staking (#302) chore: review feedback improvements fix: usage raw string literal chore: review feedback improvements [RingCache] Invalidate Cache On Redelegation Events (#239)
bryanchriswhite
removed
push-image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Human Summary
This PR adds the
DelegationClientinto theRingCacheand has it listen forEventRedelegationevents from the application in order to invalidate cache entries.It does this by listening to all events from the application module and filtering for the
EventRedelegationevent type, if it exists. This is because it seems you cannot directly subscribe to all of a specific event (custom events). They must be subscribed to based on their attributes (potential for a single delegation client that is specific for each app address). And as the subscription query supportsANDbut notORlogic we cannot directly subscribe to bothpocket.application/MsgDelegateToGatewayandpocket.application/MsgUndelegateFromGateway.AI Summary
Summary generated by Reviewpad on 10 Jan 24 01:59 UTC
This pull request includes several file diffs with various changes.
In the file 'errors.go', there are changes to variable names and error messages to improve clarity and consistency.
In the file 'msg_server_delegate_to_gateway.go', logging statements and event emission for application redelegation are modified to improve functionality and error handling.
The 'go.mod' file has changes related to dependency additions and removals.
In the file 'accquerier.go', there is a change in error handling related to deserialization of an account.
The file 'pkg/sdk/sdk.go' adds new functionality to create a new SDK instance with the given configuration.
The 'replay_client.go' file modifies code related to handling transport errors and event notifications.
The diff in the file 'delegationEventQuery' updates the subscription to application module events.
The 'cache.go' file introduces various changes related to dependency injection, methods, and logging in the cache functionality.
The 'pkg/client/events/replay_client.go' file changes comment explanations for handling transport errors and event notifications.
In the file 'cache.go' in the 'pkg/crypto/rings' package, there are changes related to dependencies, constructors, functionality, and logging.
The diff in the file adds a comment and code related to simulating connection closing.
The file 'pkg/client/delegation' has changes related to dependencies and the creation and supply of a delegation client.
The 'accquerier.go' file modifies error handling related to deserialization of an account.
In the file 'client.go', there are changes related to subscribing to events, filtering, and overriding defaults.
The 'cache.go' file in the 'pkg/crypto/rings' package has changes related to dependencies, constructors, methods, and logging.
The file 'replay_client.go' modifies code related to transport errors and event notifications.
The file 'pkg/crypto/rings/cache.go' has changes related to dependencies, methods, and logging.
The 'event.proto' file includes changes to import statements, options, and message fields.
The 'msg_server_undelegate_from_gateway.go' file adds logging and error handling improvements.
The 'interface.go' file modifies the 'RingCache' interface by adding new methods.
The file 'testproxy/relayerproxy.go' has changes related to importing packages, modifying methods, and adding dependencies.
Let me know if you need any further assistance with this diff.
Issue
Fixes N/A
Type of change
Select one or more:
Testing
make go_develop_and_testSanity Checklist