Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relayminer] chore: cleanup after 177 #190

Merged
merged 2 commits into from
Nov 16, 2023
Merged

[Relayminer] chore: cleanup after 177 #190

merged 2 commits into from
Nov 16, 2023

Conversation

bryanchriswhite
Copy link
Contributor

Summary

Human Summary

  • Updates and fixes typos in godoc comments
  • Removes unused code

AI Summary

reviewpad:summary

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Run all unit tests: make go_develop_and_test
  • Verify Localnet manually: See the instructions [here](TODO: add link to instructions)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have performed a self-review of my own code
  • I have commented my code, updated documentation and left TODOs throughout the codebase

@bryanchriswhite bryanchriswhite added relayminer Changes related to the Relayminer off-chain Off-chain business logic labels Nov 16, 2023
@bryanchriswhite bryanchriswhite self-assigned this Nov 16, 2023
@bryanchriswhite bryanchriswhite marked this pull request as ready for review November 16, 2023 08:16
red-0ne
red-0ne approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleting code ❤️ 😃

@bryanchriswhite bryanchriswhite merged commit dd34341 into main Nov 16, 2023
10 checks passed
@bryanchriswhite bryanchriswhite deleted the issues/126/chore/cleanup-after-177 branch November 16, 2023 16:44
bryanchriswhite added a commit that referenced this pull request Nov 17, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/126/test/relayer
7693a4a 
* pokt/main:
  [Relayminer] chore: cleanup after 177 (#190)
  [E2E relay test] Update to #178 (#184)
bryanchriswhite added a commit that referenced this pull request Nov 17, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/126/test/protocol
91f5c25 
* pokt/main:
  [Relayminer] chore: cleanup after 177 (#190)
  [E2E relay test] Update to #178 (#184)
bryanchriswhite added a commit that referenced this pull request Nov 17, 2023
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into issues/126/test/miner
7fdd625 
* pokt/main:
  [RelayMiner, Testing, Off-chain] test: `relayer` pkg (#193)
  [Relayminer] chore: cleanup after 177 (#190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@red-0ne red-0ne red-0ne approved these changes

@Olshansk Olshansk Awaiting requested review from Olshansk

@h5law h5law Awaiting requested review from h5law

Assignees

@bryanchriswhite bryanchriswhite

Labels
off-chain Off-chain business logic relayminer Changes related to the Relayminer
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Quality of Life
Development

Successfully merging this pull request may close these issues.
2 participants
@bryanchriswhite @red-0ne