-
Notifications
You must be signed in to change notification settings - Fork 25
[WIP][Metrics] Implement onchain cumulative relay_count and compute_units per service_id
#1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Olshansk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@red-0ne Publishing a very preliminary review.
Relying on @bryanchriswhite to review this as well.
relay_count and compute_units per service_id
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 1365) |
Olshansk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@red-0ne This PR:
- Has gotten huge
- Is definitely "good enough" for us to iterate
- Too big for me to give any good feedback at this point
- I'm getting "PR fatigue" and just want to get it over the finish line.
My only remaining question/concern is about the protocol upgrade.
I'm approving the PR, but is there anything we need to do in vNext?
I realize we're only adding things, so my gut says "no", but I want to be ultra careful about this.
I tested it against a localnet migration, worked well by starting to show onchain metrics |
|
@red-0ne Per this plan, let's prioritize this in
|
relay_count and compute_units per service_idrelay_count and compute_units per service_id
|
@red-0ne Moved this to WIP, but we will prioritize getting this in sooner rather than later. |
|
The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks. You may need to run GCP workloads (requires changing the namespace to 1365) |

Summary
Implement service usage metrics tracking for applications and suppliers
Primary Changes:
service_usage_metricsfield to bothApplicationandSupplierproto messagesSecondary changes:
Issue
relay_countandcompute_unitsperservice_id#1141Type of change
Select one or more from the following:
Sanity Checklist
assignees,reviewers,labels,project,iterationandmilestonemake docusaurus_startmake go_develop_and_testandmake test_e2edevnet-test-e2elabel to run E2E tests in CImake test_e2e_oneshot