-
Notifications
You must be signed in to change notification settings - Fork 25
[WIP] Implement historical params with height-based retrieval #1154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| // 2a. This likely also requires adding validation to the shared module params. | ||
| blockHeight := ctx.BlockHeight() | ||
|
|
||
| // TODO_IN_THIS_PR: Iterate over all claims and use the sharedParams as of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Iterate over all claims and use the sharedParams as of the
pkg/client/query/sharedquerier.go
Outdated
| func (sq *sharedQuerier) GetParams(ctx context.Context) (*sharedtypes.Params, error) { | ||
| logger := sq.logger.With("query_client", "shared", "method", "GetParams") | ||
|
|
||
| // TODO_IN_THIS_PR: Ensure that the latest cached version of the shared module |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Ensure that the latest cached version of the shared module
f0ba8c2 to
c24e0ce
Compare
c24e0ce to
3872df9
Compare
3872df9 to
7f7e3d6
Compare
Summary
Enhance params system to track historical parameters and enable retrieval based on block height.
Delay params activation until next session to avoid disturbing the current session with new params.
Primary Changes:
ParamsCacheinterface to support historical storage withGetAtHeightandSetAtHeightmethodsGetParamsAtHeightquery functionality to retrieve params effective at a specific block heightSecondary changes:
ParamsUpdatestorage with effective block heightsBeginBlockerto activate scheduled param updates at session boundariesIssue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsSanity Checklist
assignees,reviewers,labels,project,iterationandmilestonemake docusaurus_startmake go_develop_and_testandmake test_e2edevnet-test-e2elabel to run E2E tests in CI