Skip to content

Commit

Permalink
A couple comment improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
Olshansk committed May 13, 2024
1 parent 019acb0 commit 640b5d2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
3 changes: 2 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,8 @@ load_test_simple: ## Runs the simplest load test through the whole stack (appgat
# TODO_COMMUNITY - A TODO that may be a candidate for outsourcing to the community.
# TODO_DECIDE - A TODO indicating we need to make a decision and document it using an ADR in the future; https://github.com/pokt-network/pocket-network-protocol/tree/main/ADRs
# TODO_TECHDEBT - Not a great implementation, but we need to fix it later.
# TODO_BLOCKER - Similar to TECHDEBT, but of higher priority, urgency & risk prior to the next release
# TODO_BLOCKER - BEFORE MAINNET. Similar to TECHDEBT, but of higher priority, urgency & risk prior to the next release
# TODO_QOL - AFTER MAINNET. Similar to TECHDEBT, but of lower priority. Doesn't deserve a GitHub Issue but will improve everyone's life.
# TODO_IMPROVE - A nice to have, but not a priority. It's okay if we never get to this.
# TODO_OPTIMIZE - An opportunity for performance improvement if/when it's necessary
# TODO_DISCUSS - Probably requires a lengthy offline discussion to understand next steps.
Expand Down
7 changes: 4 additions & 3 deletions e2e/tests/relay.feature
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,11 @@ Feature: Relay Namespace
Then the application "app1" receives a successful relay response signed by "supplier1"

# TODO_TEST(@Olshansk):
# - Successful relay if using a gateway to proxy the relay
# - Successful relay through applicat's sovereign appgate server
# - Successful relay through gateway app is delegation to
# - Successful relay through gateway when app is delegating to multiple gateways
# - Failed relay through gateway app is not delegation to
# - Succeedful relays when using multiple suppliers for app in some session
# - Successful deduction of app's balance after claim & proof lifecycle (requires querying claims, proofs, session start/end)
# - Successful inflatino of supplier's balance after claim & proof lifecycle (requires querying claims, proofs, session start/end)
# - Error if app1 is not staked for svc1 but relay is sent
# - Error if supplier is not staked for svc1 but relay is sent
# - Error if claiming the session too early
Expand Down

0 comments on commit 640b5d2

Please sign in to comment.