Skip to content

Conversation

@jorgecuesta
Copy link
Collaborator

Summary

Add robust handling and utilities for multisignature transactions

  • Introduced new utilities in multisig.ts to handle multisignature decoding, parsing, and validation.
  • Enhanced transaction processing flows to support multisignature accounts and proper address derivation.
  • Updated transactions.ts and validator.ts to integrate multisign-specific functionality.
  • Improved error handling and added support for Secp256k1 and LegacyAminoPubKey multisig types.
  • Added placeholders for future multisign account support and related transaction properties.

TODO: Right now it will just set the signer as the from address, so we need to extend this to include multisig information that later is used on explorer to explain it is a Multisig tx.

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

- Introduced new utilities in `multisig.ts` to handle multisignature decoding, parsing, and validation.
- Enhanced transaction processing flows to support multisignature accounts and proper address derivation.
- Updated `transactions.ts` and `validator.ts` to integrate multisign-specific functionality.
- Improved error handling and added support for `Secp256k1` and `LegacyAminoPubKey` multisig types.
- Added placeholders for future multisign account support and related transaction properties.
@jorgecuesta jorgecuesta self-assigned this Jun 7, 2025
@jorgecuesta jorgecuesta added bug Something isn't working enhancement New feature or request labels Jun 7, 2025
@jorgecuesta jorgecuesta requested a review from Alann27 June 7, 2025 03:44
- Added comprehensive field definitions for multisignature transactions in `schema.graphql`.
- Updated `multisig.ts` with extended utilities to parse, validate, and handle multisig transactions.
- Integrated multisig handling into transaction processing in `transactions.ts` and `genesis.ts`.
- Introduced the `Multisig` type and related transaction properties, including `isMultisig` and `multisig` object.
- Refactored `validator.ts` to ensure consistent multisig public key address derivation logic.
- Improved documentation and added safety checks for multisig operations.
@jorgecuesta jorgecuesta merged commit 51348ca into main Jun 11, 2025
5 checks passed
@jorgecuesta jorgecuesta deleted the feature/multisign branch June 11, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants