Skip to content

Conversation

@Alann27
Copy link
Contributor

@Alann27 Alann27 commented Mar 25, 2025

Summary

Fixed handling of reason on unbonding events for Applications and Suppliers

Issue

The variable reason was of type number, receiving its value from an enum (i.e., by calling applicationUnbondingReasonFromJSON). We were incorrectly throwing an error when reason was falsy (!reason). This caused an issue when reason was the first item in the enum (with a value of 0), as 0 is a valid value but was mistakenly treated as an error.

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@Alann27 Alann27 added the bug Something isn't working label Mar 25, 2025
@Alann27 Alann27 requested a review from jorgecuesta March 25, 2025 13:43
@Alann27 Alann27 self-assigned this Mar 25, 2025
@jorgecuesta jorgecuesta merged commit 1227c73 into main Mar 25, 2025
5 of 6 checks passed
@jorgecuesta jorgecuesta deleted the bug/fix-handling-of-reason-on-unbonding-events branch March 25, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants