Fixed handling of reason on unbonding events #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed handling of reason on unbonding events for Applications and Suppliers
Issue
The variable
reasonwas of typenumber, receiving its value from an enum (i.e., by callingapplicationUnbondingReasonFromJSON). We were incorrectly throwing an error whenreasonwas falsy (!reason). This caused an issue when reason was the first item in the enum (with a value of0), as0is a valid value but was mistakenly treated as an error.Type of change
Select one or more:
Sanity Checklist