Add public key utilities and refactor address handling #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced utility functions in `pub_key.ts` to handle public key conversions and address encoding. - Refactored `primitives.ts` to use new utility methods for translating public keys to addresses. - Adjusted logging levels in `handlers.ts` for better error tracking and debugging: changed warning to error for message logging and error to trace for stack logging.
bryanchriswhite
approved these changes
Dec 9, 2024
Collaborator
bryanchriswhite
left a comment
bryanchriswhite
left a comment
There was a problem hiding this comment.
Nice one @jorgecuesta! 🙌
I only reviewed the diff here; i.e., I did not run the code and compare the resulting addresses against a known ground-truth. Assuming that you have done this exercise and are sufficiently convinced that it is producing the correct results, then this LGTM! 🚀
Collaborator
|
Also, thanks for throwing up a small one. 😉 👍 |
Alann27
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pub_key.tsto handle public key conversions and address encoding.primitives.tsto use new utility methods for translating public keys to addresses.handlers.tsfor better error tracking and debugging: changed warning to error for message logging and error to trace for stack logging.Issue
The signer of the transactions was not properly handled and due that they txs looks like was signed for a different address than which was the right one.
Type of change
Select one or more:
Sanity Checklist