fix: critical panic fixes and race condition resolution #480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 1 of quality review - addresses critical runtime panics: 1. Data Race Fixes (parallel relay handling): - Replace per-request worker pools with single shared pond pool - Use channel-based observation collection for thread-safety - Add proper mutex protection for concurrent map access 2. Nil Pointer Dereference Fixes: - Add nil checks in metrics processing functions - Add safe type assertions with ok checks - Add defensive nil checks for archival state config 3. Array Bounds Panic Fix: - Add bounds check in qos/evm/context.go before array access - Add getGenericResponseNoEndpointResponse error handler 4. Copylocks Fix: - Change archivalState parameter to pointer to avoid mutex copy 5. Race Detection Infrastructure: - Add Dockerfile.race for race detection builds - Add make e2e_test_race target - E2E tests pass with -race flag
oten91
approved these changes
Nov 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
qos/evm/context.gowith defensive bounds checkingarchivalStateby pointer instead of valuemake e2e_test_race)Test plan
make test_unit)make go_lint)make e2e_test eth)make e2e_test_race eth)