Skip to content

Conversation

@adshmh
Copy link
Contributor

@adshmh adshmh commented Oct 9, 2025

Summary

Cosmos QoS metrics include endpoint response validation errors.

@adshmh adshmh added this to the Quality of Service milestone Oct 9, 2025
@adshmh adshmh self-assigned this Oct 9, 2025
@adshmh adshmh added qos Intended to improve quality of service observability Observability catch-all Comet/Cosmos CometBFT or Cosmos SDK related work labels Oct 9, 2025
Copy link
Contributor

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adshmh I haven't reviewed this yet but can see:

  1. There are A LOT of TODO_TECHDEBTS here
  2. It improves logging & handin of JSON RPC errors in cosmos
  3. It is a net improvement overall

Should we merge it in?

@adshmh
Copy link
Contributor Author

adshmh commented Oct 16, 2025

@adshmh I haven't reviewed this yet but can see:

1. There are A LOT of TODO_TECHDEBTS here

2. It improves logging & handin of JSON RPC errors in cosmos

3. It is a net improvement overall

Should we merge it in?

I need to address some CI failures. Will merge it once CI is green.

@adshmh adshmh merged commit beacb6f into main Oct 16, 2025
16 of 18 checks passed
@adshmh adshmh deleted the fix-qos-cosmos-metrics-endpoint-errors branch October 16, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Comet/Cosmos CometBFT or Cosmos SDK related work observability Observability catch-all qos Intended to improve quality of service

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants