[Makefile] Load Test Helpers for the poral #329
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commoddity
reviewed
Jul 1, 2025
| ### Portal Tests ### | ||
| ################## | ||
|
|
||
| .PHONY: make_load_test_portal_local_path |
Contributor
There was a problem hiding this comment.
The main issue here is that in local load testing PATH has no concept of a "Portal App ID" so this target doesn't really make sense.
For testing against production the concept is valid however.
This could, of course, change if/when we update the load tests to run against PATH + GUARD locally, but even then the default GUARD configuration uses only Envoy's API key auth, not our custom Grove-legacy Portal App ID/Secret Key auth.
In order for Portal App ID to make sense for local testing we would need to update:
- Load tests to run against PATH + GUARD (currently they just run against a local PATH binary with no auth)
- GUARD to run with Grove-legacy auth (PEAS, GUARD chart set to use Grove auth) (currently GUARD uses Envoy API key auth by default, not Grove-legacy auth)
Contributor
Author
|
The new docs make this quite easy. 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP