from_request() error handling
#999
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return param not found errors instead of panic remove extra whitespace
|
Hi cookie should fix now. would you remove it again and fmt？ |
sunli829
force-pushed
the
master
branch
6 times, most recently
from
1038d6a to
54023cc
Compare
sunli829
force-pushed
the
master
branch
5 times, most recently
from
b7798f9 to
d501357
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
explode = falsepanicwe have an issue in our servers that has prevented us from using
explode = falseto accept array parameters in routes.when a request was made missing some expected query parameters with
explode = false, the request would panic on the second.unwrap()call in the previous version offrom_request.this adds some basic error handling around that scenario to prevent runtime panics.
"cookie"feature changei'm not sure why, this was just necessary to get it building. unrelated to the real change. seems to be an issue on master as well.