added HOSTNAME arg to Dockerfile #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The built docker image doesn't work for me if I don't add the ARG HOSTNAME to the Dockerfile. The reason is that webpack needs the process.env variable to be present when the build is executed.
The docker build command must also be executed with
--build-arg HOSTNAME=xxx.example.orgto inject the hostname.The fact hat webpack hard-codes the hostname into the javascript bundles means that the docker containers aren't reusable and have to be built for every domain they run on - they can't be swapped between dev, staging and production...