Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Optional Chaining Operator #2281

Closed
wants to merge 1 commit into from
Closed

Conversation

crazyair
Copy link

@crazyair crazyair commented May 25, 2024

Why

Optional chains may cause errors in some lower version environments

What

Checklist

  • Documentation updated
  • Demo added
  • Ready to be merged

Copy link

changeset-bot bot commented May 25, 2024

⚠️ No Changeset found

Latest commit: e1c497e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented May 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-spring ✅ Ready (Inspect) Visit Preview May 25, 2024 3:42am

@crazyair
Copy link
Author

The problem is that this brought in v9.6.1...v9.7.0

@joshuaellis
Copy link
Member

Optional chaining is accessible in 94% of browsers – https://caniuse.com/?search=optional%20chaining I don't think we need to omit it, you should transpile your code to the correct target should you need to target a browser that does not support it.

@crazyair
Copy link
Author

Optional chaining is accessible in 94% of browsers – https://caniuse.com/?search=optional%20chaining I don't think we need to omit it, you should transpile your code to the correct target should you need to target a browser that does not support it.

But it was good before 9.6.1.

@crazyair
Copy link
Author

@joshuaellis Modify the compiled script?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants