Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update to Yarn v4, Node.js v18, and fix a broken dependency #261

Closed
wants to merge 4 commits into from

Conversation

donmccurdy
Copy link
Member

@donmccurdy donmccurdy commented May 23, 2024

Changes in preparation for the update to glTF Transform v4. glTF Transform v4 requires a newer version of Sharp for texture compression, which in turn uses WebAssembly to support Deno environments and has some important changes to its installation process:

https://sharp.pixelplumbing.com/install#cross-platform

In general things should 'just work' for most users, but support for npm <10, yarn <3, and node.js <18 has been dropped. I've omitted the update to glTF Transform from this PR, and included only the infrastructural changes.

@donmccurdy donmccurdy requested a review from drcmda May 23, 2024 23:39
@donmccurdy
Copy link
Member Author

donmccurdy commented May 24, 2024

Based on https://sharp.pixelplumbing.com/install it sounds like Yarn v1 is still supported, but on maintenance mode. So hopefully that part won't be an issue for users, but I think it's worth going ahead and updating the Yarn version used in this repo.

@drcmda
Copy link
Member

drcmda commented Jul 13, 2024

@donmccurdy i updated all dependencies and published, im using the yarn 1 fallback atm. im kind of scared updating to a later yarn due to work projects. is there a way to fix the cli or let it use yarn-latest without forcing the project to use a specific tool?

@donmccurdy
Copy link
Member Author

donmccurdy commented Jul 13, 2024

Sharp hasn't forced a specific tool here — it allows anything except Yarn v1, or the mentioned workaround for Yarn v1. But yeah, probably a lot of people still using Yarn v1. It'd also be OK to upgrade everything except Sharp, and pin that at v0.32 indefinitely. I've been gradually switching my own projects to Yarn v4, which has been fine as long as I use nodeLinker: node-modules.

@donmccurdy
Copy link
Member Author

@drcmda OK, let's merge #253 as a starting point then, to un-break package.json. I'll look into whether we can upgrade to glTF Transform v4 here without upgrading from Yarn v1.

@donmccurdy
Copy link
Member Author

I see you merged 21033c6 already, thanks! Closing this PR.

@donmccurdy donmccurdy closed this Jul 16, 2024
@donmccurdy donmccurdy deleted the feat/yarn-v4 branch July 16, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants