Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for default export #196

Merged
merged 3 commits into from
Dec 21, 2023
Merged

feat: add option for default export #196

merged 3 commits into from
Dec 21, 2023

Conversation

davcri
Copy link
Contributor

@davcri davcri commented Apr 12, 2023

Not sure if it's worth polluting the options list for this, however I had to do it for one of my work projects and I thought to share it here. Hope it's helpful to someone.

@hrh858
Copy link

hrh858 commented Jun 19, 2023

I think this should be merged, it is actually really useful and even necessary if converting many files!

A funciton to set the name of the component would also be helpful I mean export function [Name]() {...} where we are able to tell the Name from the command.

@davcri
Copy link
Contributor Author

davcri commented Jun 19, 2023

A function to set the name of the component would also be helpful I mean export function Name {...} where we are able to tell the Name from the command.

This would be really nice. It would be nice to default the export component name to the GLB root node name. Is it a bad idea?

@drcmda any thoughts on this? I could update the PR if needed

@drcmda drcmda merged commit 199157b into pmndrs:master Dec 21, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants