-
Notifications
You must be signed in to change notification settings - Fork 626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] update for R3F v9 #1941
base: v10
Are you sure you want to change the base?
[feat] update for R3F v9 #1941
Conversation
# Conflicts: # src/core/Environment.tsx # src/core/useEnvironment.tsx
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@joshuaellis I'd like to appeal to you about upgrading |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Now builds. Known issues are with components that access R3F internals like |
Sorry I missed this. Do you know what the impact looks like? I can probably find some time for you haha |
I believe it is just types, maybe related to this: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#the-jsx-namespace-in-typescript We also moved types for R3F to |
# Conflicts: # src/core/Text.tsx
Co-authored-by: Cody Bennett <[email protected]>
This reverts commit 482cc39.
@CodyJasonBennett I'm stuck again getting the test to run. Some kind of source map issue. |
Co-authored-by: Cody Bennett <[email protected]>
This is untested. It is a quick conversion of Drei v9 to use R3F v9 without any typing errors.