fix: <Select/>
when !multiple || !box
#1613
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When the props
multiple
andbox
are defined,downed
is being set through eventListeners set on the window inside an effect. If they are not set,downed
was initially never set, which causedonChange
to never run.An example of
Select
not working is theWith <Select/>
-story ofTransformControls
.What
const shouldDragSelect = multiple && box
<group/>
in case!shouldDragSelect
so thatshouldDragSelect === true
downed
is being set through the event-listeners set inside the effectshouldDragSelect === false
downed
is being set whenever one ofSelect
's children is being clicked.Besides that I also added
shouldDragSelect
as a dependency of the effect, before this commit themultiple
orbox
props weren't included, which could have caused bugs too.Checklist