-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse arrays #1373
Sparse arrays #1373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before we proceed, could you please verify (locally) that the tests pass if you change to sparray somewhere in the models?
I confirm that all tests pass when we change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks to both of you for quick and good work!
* MAINT: Add sps.sparray to isinstance checks * TST: sparse_array support in ad test * MAINT: Applied suggestions from the review --------- Co-authored-by: Ingrid Kristine Jacobsen <[email protected]>
Proposed changes
This covers #1319. Made by @IngridKJ and me.
Types of changes
What types of changes does this PR introduce to PorePy?
Put an
x
in the boxes that apply.Checklist
Put an
x
in the boxes that apply or explain briefly why the box is not relevant.pytest
was run with the--run-skipped
flag.