Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse arrays #1373

Merged
merged 4 commits into from
Mar 8, 2025
Merged

Sparse arrays #1373

merged 4 commits into from
Mar 8, 2025

Conversation

Yuriyzabegaev
Copy link
Contributor

Proposed changes

This covers #1319. Made by @IngridKJ and me.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

Copy link
Contributor

@IvarStefansson IvarStefansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before we proceed, could you please verify (locally) that the tests pass if you change to sparray somewhere in the models?

@Yuriyzabegaev
Copy link
Contributor Author

Before we proceed, could you please verify (locally) that the tests pass if you change to sparray somewhere in the models?

I confirm that all tests pass when we change coo_matrix to coo_array in cell_projections and face_projections in grid_operators.py.

@IvarStefansson IvarStefansson self-requested a review March 8, 2025 07:31
Copy link
Contributor

@IvarStefansson IvarStefansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks to both of you for quick and good work!

@Yuriyzabegaev Yuriyzabegaev merged commit 26ea7bf into develop Mar 8, 2025
6 checks passed
@Yuriyzabegaev Yuriyzabegaev deleted the 1319-sparray branch March 8, 2025 08:12
keileg pushed a commit that referenced this pull request Mar 10, 2025
* MAINT: Add sps.sparray to isinstance checks

* TST: sparse_array support in ad test

* MAINT: Applied suggestions from the review

---------

Co-authored-by: Ingrid Kristine Jacobsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Perpare Ad framework for the use of scipy sparse arrays
3 participants