Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Deleted outdated todos #1372

Merged
merged 3 commits into from
Mar 10, 2025
Merged

MAINT: Deleted outdated todos #1372

merged 3 commits into from
Mar 10, 2025

Conversation

keileg
Copy link
Contributor

@keileg keileg commented Mar 6, 2025

Mainly plain deletions, but I also expanded documentation at a few points.

Most of the deleted comments were fair and should have been fixed in a world with infinite resources, but chances are they would have gone unaddressed for a few more years if left alone.

Proposed changes

Contributions to PorePy are highly appreciated. Clearly explain why this pull request (PR) is needed and why it should be accepted. If this PR solves an issue, explain how it is done. Please, also summarise the changes to the code.

Types of changes

What types of changes does this PR introduce to PorePy?
Put an x in the boxes that apply.

  • Minor change (e.g., dependency bumps, broken links).
  • Bugfix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).
  • Testing (contribution related to testing of existing or new functionality).
  • Documentation (contribution related to adding, improving, or fixing documentation).
  • Maintenance (e.g., improve logic and performance, remove obsolete code).
  • [] Other:

Checklist

Put an x in the boxes that apply or explain briefly why the box is not relevant.

  • The documentation is up-to-date.
  • Static typing is included in the update.
  • This PR does not duplicate existing functionality.
  • The update is covered by the test suite (including tests added in the PR).
  • If new skipped tests have been introduced in this PR, pytest was run with the --run-skipped flag.

Copy link
Contributor

@IvarStefansson IvarStefansson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only minor comments. Feel free to resolve as you see fit.

keileg and others added 3 commits March 10, 2025 08:40
Mainly plain deletions, but I took action at a few points
Applies to split_grid (fracs) and geometry_property_checks
@keileg keileg merged commit 9fc39d8 into develop Mar 10, 2025
6 checks passed
@keileg keileg deleted the address_todos branch March 10, 2025 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants