-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix Kotest based tests #5022
Conversation
- Renamed to BranchingExprsTests so that it is picked up by surefire - Fix cast context
Generated by 🚫 Danger |
pmd-java/src/test/kotlin/net/sourceforge/pmd/lang/java/ast/OverrideResolutionTest.kt
Outdated
Show resolved
Hide resolved
- introduce parserTestContainer - use either parserTest or parserTestContainer with should/doTest - parserTestGroup is now private - this is to limit DSL options - with too many options maintainability suffers - parserTestContainer should be used instead - there were only 2 test classes, that used parserTestGroup
This looks good, thanks :) |
FYI - I was now investigating the root cause for the following problem: We have a disabled test in
It turns out, that the surefire/junit-platform integration is tailored against methods based test frameworks, where each test is based on a method. For kotest, when it reports the tests up to junit-platform, it only provides a class source (and not a method source): https://github.com/kotest/kotest/blob/6f371fbd0af65577f9a5092d3abab017613afa98/kotest-runner/kotest-runner-junit5/src/jvmMain/kotlin/io/kotest/runner/junit/platform/descriptors.kt#L34 |
Describe the PR
The changes are in pmd-java only:
Related issues
Ready?
./mvnw clean verify
passes (checked automatically by github actions)