Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Improve AssertionUtil messages #4905

Merged
merged 2 commits into from
Mar 30, 2024

Conversation

adangel
Copy link
Member

@adangel adangel commented Mar 29, 2024

Describe the PR

We sometimes don't give much info, when we reach an assertion.
Especially for #4885, we don't preserve the original exception.
I've updated a couple of places, where we throw AssertionUtil.shouldNotReachHere.

Related issues

Ready?

  • Added unit tests for fixed bug/feature
  • Passing all unit tests
  • Complete build ./mvnw clean verify passes (checked automatically by github actions)
  • Added (in-code) documentation (if needed)

@adangel adangel added the in:pmd-internals Affects PMD's internals label Mar 29, 2024
@adangel adangel added this to the 7.0.1 milestone Mar 29, 2024
@pmd-test
Copy link

1 Message
📖 Compared to master:
This changeset changes 0 violations,
introduces 0 new violations, 0 new errors and 0 new configuration errors,
removes 0 violations, 0 errors and 0 configuration errors.
Download full report as build artifact

Generated by 🚫 Danger

@jsotuyod jsotuyod merged commit a47a301 into pmd:master Mar 30, 2024
3 checks passed
@adangel adangel deleted the issue-4885-assertions branch April 2, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:pmd-internals Affects PMD's internals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants