[java] AssertionError: Method should be accessible #4885
Assignees
Labels
a:bug
PMD crashes or fails to analyse a file.
was:unreproducible
A bug report that cannot be reproduced - reporter should provide a MWE
Comments
|
Third exception: |
|
So, I think this is around this problem:
This fails with no such method... Unfortunately, I couldn't yet reproduce the problem.... |
|
@Meijuh would you mind sharing the output of I have a suspicion as to what may be triggering this, but would love to confirm. I believe this is down to a JVM bug, where some versions choke on scenarios similar to ours… In short,
The exact same thing happens to all other literal types, such as I've seen some reports on JDK where similar scenarios caused failures consistent with this stacktrace. They were mostly reported on older JVMs, but that doesn't mean Java 11 releases existing at that time were not affected. If this is true:
|
openjdk version "11.0.22" 2024-01-16
OpenJDK Runtime Environment (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7)
OpenJDK 64-Bit Server VM (Red_Hat-11.0.22.0.7-1) (build 11.0.22+7, mixed mode, sharing)I'm quite sure I was using this version when I reported this issue, but now when I'm trying to reproduce the issue, I can't... I will report whenever the problem pops up again. |
adangel
changed the title
adangel
changed the title
adangel
changed the title
|
It could be a JVM issue, yes. 11.0.22 is the current version. Searching the bug database, I only found old problems regarding this constellation, e.g. https://bugs.openjdk.org/browse/JDK-7087658. We unfortunately don't log the causing exception. I'll create a PR to fix the logging of the IllegalAccessException, so that we have the full stacktrace, in case this happens again. Then maybe we can see, what the underlying issue might be - if any. Is this a bigger project, long running PMD analysis? I'm asking, because as far as I read, some bugs are only appearing when the hotspot compiler comes in and has a bug, so that this problem would never be reproducible with a simple test case. Gradle uses a gradle daemon process, which gives the opportunity for the JVM to do all kinds of optimizations, and maybe only then this problem shows after a while. And it disappears when the JVM is started fresh. Let's keep this issue open and see, if this problem happens again. |
adangel
added a commit
to adangel/pmd
that referenced
this issue
Mar 29, 2024
This is a test case for pmd#4885, but doesn't reproduce the problem.
4 tasks
jsotuyod
added
the
needs:pmd7-revalidation
|
reproduced on azul zulu 11.0.19 |
jsotuyod
removed
the
needs:pmd7-revalidation
adangel
added
the
was:unreproducible
|
I'm closing this now as the problem is not reproducible. It might have been fixed already in the latest JDK versions. |
|
I still have this even with azul zulu 11.0.23 |
|
@sabberworm Thanks for the info. |
|
Back when I wrote in, I wasn’t yet using PMD 7.1.0 but now I’ve upgraded and I’m seeing the issue sporadically still (alas, not reproducibly). I am using gradle with the quality plugin and that is running PMD. Stack TraceAlso, it always happens on a different token. Sometimes a string literal, other times a number literal. |
|
@sabberworm thanks. Have you tried a different JRE other than Zulu? |
|
@sabberworm The error message in the stack trace indicates, that this was still using PMD 7.0.0. Please post a new stacktrace with PMD 7.1.0, when this happens again. |
We should really do that for 7.2.0 |
oowekyala
added a commit
to oowekyala/pmd
that referenced
this issue
May 16, 2024
oowekyala
added a commit
to oowekyala/pmd
that referenced
this issue
May 16, 2024
4 tasks
|
@adangel Ah yes, you’re right I did still use the old version. I had a manual reference to the dependency, so just changing the version in the quality plugin didn’t actually update PMD, my bad. I tried a few times but couldn’t trigger the problem with 7.1.0. Will report back when I do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Affects PMD Version:
7.0.0
Description:
Errors about unreachable methods are intermittently (only 50% of the times) produced.
Exception Context:
[1:Rule applied on node=!debug only! [StringLiteral:9:29]"retracted"]
at net.sourceforge.pmd.util.AssertionUtil.shouldNotReachHere(AssertionUtil.java:219)
Exception Context:
[1:Rule applied on node=!debug only! [NumericLiteral:11:21]0]
Exception Context:
[1:Rule applied on node=!debug only! [StringLiteral:15:31]"no classes should use field injection"]
Exception Stacktrace:
at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.lambda$executeIfValid$1(ExecuteActionsTaskExecuter.java:130) .... Caused by: : net.sourceforge.pmd.util.ContextedAssertionError: This should be unreachable: Method should be accessible java.lang.IllegalAccessException: no such method: net.sourceforge.pmd.lang.java.ast.ASTNumericLiteral.getLiteralText()Chars/invokeVirtual Exception Context: [1:Rule applied on node=!debug only! [NumericLiteral:11:21]0] --------------------------------- at org.apache.tools.ant.dispatch.DispatchUtils.execute(DispatchUtils.java:109) .... Caused by: net.sourceforge.pmd.util.ContextedAssertionError: This should be unreachable: Method should be accessible java.lang.IllegalAccessException: no such method: net.sourceforge.pmd.lang.java.ast.ASTNumericLiteral.getLiteralText()Chars/invokeVirtual Exception Context: [1:Rule applied on node=!debug only! [NumericLiteral:11:21]0] --------------------------------- at net.sourceforge.pmd.util.AssertionUtil.shouldNotReachHere(AssertionUtil.java:219) at net.sourceforge.pmd.lang.rule.xpath.impl.AttributeAxisIterator.lambda$getWrappersForClass$1(AttributeAxisIterator.java:92) at [email protected]/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) at [email protected]/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:177) at [email protected]/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948) at [email protected]/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) at [email protected]/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) at [email protected]/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) at [email protected]/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) at [email protected]/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578) at net.sourceforge.pmd.lang.rule.xpath.impl.AttributeAxisIterator.getWrappersForClass(AttributeAxisIterator.java:95) at [email protected]/java.util.concurrent.ConcurrentHashMap.computeIfAbsent(ConcurrentHashMap.java:1705) at net.sourceforge.pmd.lang.rule.xpath.impl.AttributeAxisIterator.<init>(AttributeAxisIterator.java:82) at net.sourceforge.pmd.lang.ast.Node.getXPathAttributesIterator(Node.java:278) at net.sourceforge.pmd.lang.rule.xpath.internal.AstElementNode.getLightAttributes(AstElementNode.java:105) at net.sourceforge.pmd.lang.rule.xpath.internal.AstElementNode.getAttributeValue(AstElementNode.java:178) at net.sf.saxon.expr.AttributeGetter.evaluateItem(AttributeGetter.java:127) at net.sf.saxon.expr.ValueComparison.effectiveBooleanValue(ValueComparison.java:357) at net.sf.saxon.expr.FilterIterator$NonNumeric.matches(FilterIterator.java:180) at net.sf.saxon.expr.FilterIterator.getNextMatchingItem(FilterIterator.java:77) at net.sf.saxon.expr.FilterIterator.next(FilterIterator.java:63) at net.sf.saxon.om.FocusTrackingIterator.next(FocusTrackingIterator.java:76) at net.sf.saxon.expr.FilterIterator.getNextMatchingItem(FilterIterator.java:76) at net.sf.saxon.expr.FilterIterator.next(FilterIterator.java:63) at net.sf.saxon.om.FocusTrackingIterator.next(FocusTrackingIterator.java:76) at net.sf.saxon.expr.FilterIterator.getNextMatchingItem(FilterIterator.java:76) at net.sf.saxon.expr.FilterIterator.next(FilterIterator.java:63) at net.sourceforge.pmd.lang.rule.xpath.internal.SaxonXPathRuleQuery.evaluate(SaxonXPathRuleQuery.java:127) at net.sourceforge.pmd.lang.rule.xpath.XPathRule.apply(XPathRule.java:101) at net.sourceforge.pmd.lang.rule.RuleReference.apply(RuleReference.java:415) at net.sourceforge.pmd.lang.rule.internal.RuleApplicator.applyOnIndex(RuleApplicator.java:77) at net.sourceforge.pmd.lang.rule.internal.RuleApplicator.apply(RuleApplicator.java:57) at net.sourceforge.pmd.lang.rule.internal.RuleSets.apply(RuleSets.java:155) at net.sourceforge.pmd.lang.impl.PmdRunnable.processSource(PmdRunnable.java:140) at net.sourceforge.pmd.lang.impl.PmdRunnable.run(PmdRunnable.java:80) at [email protected]/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at [email protected]/java.util.concurrent.FutureTask.run(FutureTask.java:264) ... 3 more```Code Sample demonstrating the issue:
I'm not a 100% sure, but these lines of code seem to be involved in producing the errors.
Steps to reproduce:
Please provide detailed steps for how we can reproduce the bug.
./gradlew clean build --stacktraceRunning PMD through: Gradle
JDK 11
The text was updated successfully, but these errors were encountered: