Fix SRT/WebVTT subtitle downloads #158
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are several issues with using Date().toISOString(): - The hours field is mod 24 - The decimal separator is '.' which is correct for WebVTT but not for SRT - The output string technically can be one of two formats, changing the substring range. - No checks for >=100 hours, which is not supported in SRT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR most importantly fixes the SRT download option, which was producing invalid output files with a
.decimal separator rather than the correct,separator (fixes #118). Additionally this fixes several other errors in the SRT and WebVTT output when dealing with very large timestamps (see commit message for details). It also takes advantage of the fact that the hours are optional in WebVTT to save a couple of bytes on small timecodes < 1 hour.