Unified hover: use legend.tracegroupgap in mock legend
#6875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. |
alexcjohnson
reviewed
Feb 2, 2024
| @@ -1139,7 +1139,7 @@ function createHoverText(hoverData, opts) { | |||
| bgcolor: hoverlabel.bgcolor, | |||
| bordercolor: hoverlabel.bordercolor, | |||
| borderwidth: 1, | |||
| tracegroupgap: 7, | |||
| tracegroupgap: fullLayout.legend ? fullLayout.legend.tracegroupgap : undefined, | |||
There was a problem hiding this comment.
Hmm I see we have the same logic on the next line for traceorder but this most likely predates multiple legends. I suppose this is going to give the correct behavior 99% of the time, but at some point we may want to look for which legend say the first trace shown in hover is included in, and use the tracegroupgap from that one.
Do we want to fall back on undefined or would the previous default of 7 be better if there's no legend at all? Or maybe change it to 10, which is the default tracegroupgap when we DO have a legend, so adding an unstyled legend won't change the behavior here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a mock legend in the
unifiedhover label, read the user-providedlegend.tracegroupgapparameter instead of hardcodingtracegroupgap: 7. To make the tooltip match the legend.