-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Track data changes #47
base: master
Are you sure you want to change the base?
Conversation
pylint 2.14.4 astroid 2.11.6 Python 3.8.2 (tags/v3.8.2:7b3ab59, Feb 25 2020, 23:03:10) [MSC v.1916 64 bit (AMD64)]
…ndererName, rows, rowOrder, vals and valueFilter can be updated and adding buttons to usage.py to demonstrate that
The build is failing due to pylint failing to run (e.g. here) which is due to this restriction on asteriod. If I remove that line then pylint locally runs fine. |
@alexcjohnson @nicolaskruchten - Is there anything outstanding with this PR? Considering that issue #10 was first opened in 2019 and this is (imo) a major pain-point in working with this component (which is otherwise a great add to the Dash toolkit), it would be great if we could prioritize getting this merged to master and released. |
@chriddyp any chance you could help move this PR along? |
Any resolution to get this merged in? |
Hey@AdrianIssott, I applied your changes for my pivot table but I filter my columns or rows, the valueFilter argument is still empty on my callbacks. Does it work for you or did I understand its functionality wrong? |
@candas-unal-work, it does work for me. I updated |
@AdrianIssott OK this is interesting: When I tried the Thank you. |
Well that's not great and suggests an improvement is needed on this PR. However, there's little point in me doing that given it's totally stalled |
I understand. But thank you again for the PR, it solved my many problems @AdrianIssott . |
How could this project be revived? |
I think pivot table is a great tool, has a lot of potentials but the people at plotly are not as interested, or so it seems. @alexcjohnson @nicolaskruchten . |
About
This PR fixes #10 and as a bonus side-affect makes all of the previously read-only properties of the
dash_pivottable.PivotTable
writeable.Description of changes
usage.py
to demonstrate that changes todata
are not being picked up by the pivot table.props
values and not writing tostate
as inspired by the following console warning emitted when loadingusage.py
:usage.py
to demonstrate that is indeed now possible.Pre-Merge checklist
npm run build:all
.Reference Issues
Fixes #10