Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not display warning when a task has multiple notebook outputs #1021

Conversation

grnnja
Copy link
Contributor

@grnnja grnnja commented Sep 12, 2022

Describe your changes

Turns out this wasn't actually a problem, but we weren't testing for it so I added a test.
#980 (comment)

Issue ticket number and link

Closes #980

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added thorough tests (when necessary).
  • I have added the right documentation (when needed). Product update? If yes, write one line about this update.

@edublancas edublancas changed the base branch from master to dev/fix-warning-1021 October 7, 2022 20:56
@edublancas edublancas changed the title test multiple outputs in convert with kwargs not warning do not display warning when a task has multiple notebook outputs Oct 7, 2022
@edublancas edublancas merged commit d3e16d1 into ploomber:dev/fix-warning-1021 Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Erroneous warning
2 participants