[Doc] Dash - auto change in routing | note #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
edublancas
reviewed
Nov 28, 2024
|
|
||
| _ERROR: We were not able to modify your Routing automatically_ | ||
|
|
||
| _INSTRUCTION: Please add `url_base_pathname="/application/"` to `app = Dash(__name__, ...)`_ |
There was a problem hiding this comment.
does this happen because of the marketing banner?
There was a problem hiding this comment.
Yes, for this comment: https://github.com/ploomber/cloud-backend/pull/1626#discussion_r1861149148
Bryan recommended to add a notice
- But the replace should always work, since the search is done in every python files of the project. (I handle all the cases, with multiple parameters, if the
url_base_pathnameis already there, the ordering, and more..) - So we could not mention it in the Doc. And if ever if fails (it should not, it's thoroughly tested), a is log emitted.
There was a problem hiding this comment.
(So this PR is optional)
edublancas
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://ploomber-doc--293.org.readthedocs.build/en/293/