Skip to content

Prepare release 2.3.0 #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 20, 2025
Merged

Prepare release 2.3.0 #384

merged 6 commits into from
Jun 20, 2025

Conversation

petschki
Copy link
Member

Note: if this all goes green, then mockup==5.4.0 will be released, before merging this. But there are likely some robottests breaking here right now.

@pgrunewald I put you in CC ... maybe you can take a look too.

@mister-roboto
Copy link

@petschki thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@petschki
Copy link
Member Author

@jenkins-plone-org please run jobs

@pgrunewald
Copy link

I just tested it locally. It has all the changes and works. I just noticed a little visual glitch:

image

The icon somehow duplicates sometimes (not everytime) on initial load of folder_contents. I'm not aware that the new code does anything special. Maybe it's something on my setup/browser. Besides of that, functionally it works as expected and is already a good improvement.

Copy link

@pgrunewald pgrunewald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave my approval. Unless the visual glitch is just for me or is tolerable for the moment, it'd be good to go.

@pgrunewald
Copy link

@petschki The changelog entry is missing. Can you please add one for this release?

@petschki
Copy link
Member Author

Yes of course. I just wanted to release a final mockup 5.4.0 before making this ready. Will do now.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM when I try it out.

Jenkins is green, except for one job which has one test error: "Could not connect to the playwright process at port 39747." That seems safe to ignore.

@petschki petschki merged commit c18428e into master Jun 20, 2025
13 of 14 checks passed
@petschki petschki deleted the release-2.3.0-b1 branch June 20, 2025 07:02
@petschki
Copy link
Member Author

I'll release 2.3.0 now

@petschki
Copy link
Member Author

Released 2.3.0 ... thanks @pgrunewald for this improvement. Really appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants