-
-
Notifications
You must be signed in to change notification settings - Fork 14
Prepare release 2.3.0 #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@petschki thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
I just tested it locally. It has all the changes and works. I just noticed a little visual glitch: The icon somehow duplicates sometimes (not everytime) on initial load of folder_contents. I'm not aware that the new code does anything special. Maybe it's something on my setup/browser. Besides of that, functionally it works as expected and is already a good improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I leave my approval. Unless the visual glitch is just for me or is tolerable for the moment, it'd be good to go.
@petschki The changelog entry is missing. Can you please add one for this release? |
Yes of course. I just wanted to release a final mockup 5.4.0 before making this ready. Will do now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when I try it out.
Jenkins is green, except for one job which has one test error: "Could not connect to the playwright process at port 39747." That seems safe to ignore.
I'll release |
Released |
Note: if this all goes green, then
mockup==5.4.0
will be released, before merging this. But there are likely some robottests breaking here right now.@pgrunewald I put you in CC ... maybe you can take a look too.