-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate plone.exportimport documentation from its docs to its README.md and to Plone 6 Documenation #47
Conversation
…md and to Plone 6 Documenation Refs: plone/documentation#1842 Closes #46
…md and to Plone 6 Documenation Refs: plone/documentation#1842 Closes #46
@stevepiercy thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
@jenkins-plone-org please run jobs |
Something unrelated to this PR broke the Jenkins build: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly fine, thanks!
Some change requests.
Indeed unrelated. Actually it is useless to run Jenkins jobs for this repository: its tests are not found. The reason is the same as in this issue for We could configure mr.roboto to not add its remark. But maybe we will fix the issue in the near future. |
Co-authored-by: Maurits van Rees <[email protected]>
I'll forego running Jenkins again, as it is pointless. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Important
Merge related PR first: plone/documentation#1842
Closes #46