Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate plone.exportimport documentation from its docs to its README.md and to Plone 6 Documenation #47

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

stevepiercy
Copy link
Contributor

@stevepiercy stevepiercy commented Jan 30, 2025

Important

Merge related PR first: plone/documentation#1842

Closes #46

@mister-roboto
Copy link

@stevepiercy thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@stevepiercy
Copy link
Contributor Author

@jenkins-plone-org please run jobs

@stevepiercy
Copy link
Contributor Author

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly fine, thanks!
Some change requests.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@mauritsvanrees
Copy link
Member

Something unrelated to this PR broke the Jenkins build:

Indeed unrelated.

Actually it is useless to run Jenkins jobs for this repository: its tests are not found. The reason is the same as in this issue for plone.distribution.

We could configure mr.roboto to not add its remark. But maybe we will fix the issue in the near future.

@stevepiercy
Copy link
Contributor Author

I'll forego running Jenkins again, as it is pointless.

Copy link
Member

@mauritsvanrees mauritsvanrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mauritsvanrees mauritsvanrees merged commit a3b1e0f into main Jan 30, 2025
9 of 11 checks passed
@mauritsvanrees mauritsvanrees deleted the migrate-docs-46 branch January 30, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Publish docs or RTD pull request previews?
3 participants